ArgsTable: Fix union type splitting #11868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shilman Can we merge this fix? |
shilman
reviewed
Aug 15, 2020
| const cannotBeSafelySplitted = /[(){}[\]<>]/.test(summaryAsString); | ||
|
|
||
| if (cannotBeSafelySplitted) { | ||
| return <ArgText text={summaryAsString} simple={summaryAsString.includes('|')} />; |
There was a problem hiding this comment.
Can you explain simple to me? Don't understand why we need it.
There was a problem hiding this comment.
Sorry I have a vacation. Simple is turning on and off styling of values (border, background...). And I used it because when you have non splitted values it looked strange with styling.
shilman
changed the title
ndelangen
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #11840
What I did
This is more like hotfix, I disabled splitting for complex union types containing
(),{},[],<>. I'll need more time to find out how to properly split those complex union types.How to test