feat(rulesets): add rule to check if messageId is defined #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmatatjahu
added
enhancement
magicmatatjahu
requested review from
smoya,
jonaslagoni and
a team
as code owners
magicmatatjahu
changed the title
9 tasks
|
I have to update that PR to handle also cases with traits. For |
smoya
reviewed
Sep 19, 2022
There was a problem hiding this comment.
💯 👍
I +1 to the change. I'm concerned about the possible breaking change this could become.
If any user relies on the operationId for a critical feature, this change will possibly make their apps to fail.
I believe this should be considered a breaking change, but let's see what other maintainers say.
magicmatatjahu
force-pushed
the
asyncapi/operationId-optional
branch
2 times, most recently
from
a743b87
to
d9a6cad
Compare
Merged
4 tasks
|
Yeah, I'd say it's a breaking change indeed. |
magicmatatjahu
force-pushed
the
asyncapi/operationId-optional
branch
from
d9a6cad
to
d4990cb
Compare
| @@ -297,7 +303,7 @@ channels: | |||
|
|
|||
| ### asyncapi-operation-operationId | |||
|
|
|||
| This operation ID is essentially a reference for the operation. Tools may use it for defining function names, class method names, and even URL hashes in documentation systems. | |||
| Each Operation must have an "operationId" field defined. Tools can use it to define function names, class method names and even URL hashes in documentation systems. | |||
There was a problem hiding this comment.
Suggested change
| Each Operation must have an "operationId" field defined. Tools can use it to define function names, class method names and even URL hashes in documentation systems. | |
| Each Operation must have an "operationId" field defined. Tools may use it to define function names, class method names, and even URL hashes in documentation systems. |
philsturgeon
approved these changes
Oct 11, 2022
P0lip
force-pushed
the
develop
branch
2 times, most recently
from
cf3ae99
to
761c65a
Compare
P0lip
force-pushed
the
develop
branch
4 times, most recently
from
4b6a9e1
to
33deb2b
Compare
P0lip
force-pushed
the
develop
branch
3 times, most recently
from
dc9d7f4
to
44c40e2
Compare
P0lip
force-pushed
the
develop
branch
4 times, most recently
from
02ec0d4
to
84faec8
Compare
P0lip
force-pushed
the
develop
branch
3 times, most recently
from
9e92f34
to
6d09915
Compare
P0lip
force-pushed
the
develop
branch
3 times, most recently
from
dc90b7a
to
c22f408
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Does this PR introduce a breaking change?
Additional context
asyncapi-operation-operationIdrule from error to warningasyncapi-message-messageIdrule, with similar functionality likeasyncapi-operation-operationIdcc @jonaslagoni @smoya