feat(rulesets): revert operationId changes

stoplightio · Sep 27, 2022 · d4990cb · d4990cb
1 parent 633fbfa
commit d4990cb
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 10 deletions.
diff --git a/docs/reference/asyncapi-rules.md b/docs/reference/asyncapi-rules.md
@@ -261,7 +261,7 @@ channels:
 
 ### asyncapi-message-messageId
 
-Each Message should have a "messageId" field defined. It is recommended, but still optional. Tools can use it to define function names, class method names and even URL passwords in documentation systems.
+Each Message should have a "messageId" field defined. It is recommended, but still optional. Tools can use it to define function names, class method names and even URL hashes in documentation systems.
 
 **Recommended:** Yes
 
@@ -303,7 +303,7 @@ channels:
 
 ### asyncapi-operation-operationId
 
-Each Operation should have a "operationId" field defined. It is recommended, but still optional. Tools can use it to define function names, class method names and even URL passwords in documentation systems.
+Each Operation must have an "operationId" field defined. Tools can use it to define function names, class method names and even URL hashes in documentation systems.
 
 **Recommended:** Yes
 

diff --git a/packages/rulesets/src/asyncapi/__tests__/asyncapi-operation-operationId.test.ts b/packages/rulesets/src/asyncapi/__tests__/asyncapi-operation-operationId.test.ts
@@ -56,14 +56,14 @@ testRule('asyncapi-operation-operationId', [
     },
     errors: [
       {
-        message: 'Operation should have a "operationId" field defined.',
+        message: 'Operation must have an "operationId" field defined.',
         path: ['channels', 'one', 'publish'],
-        severity: DiagnosticSeverity.Warning,
+        severity: DiagnosticSeverity.Error,
       },
       {
-        message: 'Operation should have a "operationId" field defined.',
+        message: 'Operation must have an "operationId" field defined.',
         path: ['channels', 'one', 'subscribe'],
-        severity: DiagnosticSeverity.Warning,
+        severity: DiagnosticSeverity.Error,
       },
     ],
   },
@@ -85,9 +85,9 @@ testRule('asyncapi-operation-operationId', [
     },
     errors: [
       {
-        message: 'Operation should have a "operationId" field defined.',
+        message: 'Operation must have an "operationId" field defined.',
         path: ['channels', 'one', 'publish'],
-        severity: DiagnosticSeverity.Warning,
+        severity: DiagnosticSeverity.Error,
       },
     ],
   },

diff --git a/packages/rulesets/src/asyncapi/index.ts b/packages/rulesets/src/asyncapi/index.ts
@@ -269,9 +269,10 @@ export default {
       },
     },
     'asyncapi-operation-operationId': {
-      description: 'Operation should have a "operationId" field defined.',
+      description: 'Operation must have an "operationId" field defined.',
+      severity: 'error',
       recommended: true,
-      type: 'style',
+      type: 'validation',
       given: ['$.channels[*][publish,subscribe]', '$.components.channels[*][publish,subscribe]'],
       then: {
         function: asyncApi2CheckId,