Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid deprecated notice when using symfony/config > 4.2 #383

Closed
wants to merge 3 commits into from
+12 −8
Closed

Avoid deprecated notice when using symfony/config > 4.2 #383

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d8b6ad
Avoid deprecated notice when using symfony/config > 4.2
Dec 5, 2018
a9e03b5
Correct variables
garethbraid89 Dec 21, 2018
6b5e25c
Use $treeBuilder instance instead of FQN
Dec 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 12 additions & 8 deletions DependencyInjection/Configuration.php
View file
Open in desktop
Expand Up @@ -14,8 +14,9 @@ class Configuration implements ConfigurationInterface
*/
public function getConfigTreeBuilder()
{
$treeBuilder = new TreeBuilder();
$rootNode = $treeBuilder->root('stof_doctrine_extensions');
$treeBuilder = new TreeBuilder('stof_doctrine_extensions');
// Keep compatibility with symfony/config < 4.2
$rootNode = \method_exists(TreeBuilder::class, 'getRootNode') ? $treeBuilder->getRootNode() : $treeBuilder->root('stof_doctrine_extensions');

$rootNode
->append($this->getVendorNode('orm'))
Expand All @@ -41,8 +42,9 @@ public function getConfigTreeBuilder()
*/
private function getVendorNode($name)
{
$treeBuilder = new TreeBuilder();
$node = $treeBuilder->root($name);
$treeBuilder = new TreeBuilder($name);
// Keep compatibility with symfony/config < 4.2
$rootNode = \method_exists(TreeBuilder::class, 'getRootNode') ? $treeBuilder->getRootNode() : $treeBuilder->root($name);
odolbeau marked this conversation as resolved.
Show resolved Hide resolved

$node
->useAttributeAsKey('id')
Expand All @@ -67,8 +69,9 @@ private function getVendorNode($name)

private function getClassNode()
{
$treeBuilder = new TreeBuilder();
$node = $treeBuilder->root('class');
$treeBuilder = new TreeBuilder('class');
// Keep compatibility with symfony/config < 4.2
$rootNode = \method_exists(TreeBuilder::class, 'getRootNode') ? $treeBuilder->getRootNode() : $treeBuilder->root('class');
odolbeau marked this conversation as resolved.
Show resolved Hide resolved

$node
->addDefaultsIfNotSet()
Expand Down Expand Up @@ -121,8 +124,9 @@ private function getClassNode()

private function getUploadableNode()
{
$treeBuilder = new TreeBuilder();
$node = $treeBuilder->root('uploadable');
$treeBuilder = new TreeBuilder('uploadable');
// Keep compatibility with symfony/config < 4.2
$rootNode = \method_exists(TreeBuilder::class, 'getRootNode') ? $treeBuilder->getRootNode() : $treeBuilder->root('uploadable');
odolbeau marked this conversation as resolved.
Show resolved Hide resolved

$node
->addDefaultsIfNotSet()
Expand Down