Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deprecated notice when using symfony/config > 4.2 #383

Closed
wants to merge 3 commits into from

Conversation

odolbeau
Copy link

@odolbeau odolbeau commented Dec 5, 2018

Copy link

@matthieumota matthieumota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I purpose a more concise syntax

$rootNode = \method_exists(TreeBuilder::class, 'getRootNode') ? $treeBuilder->getRootNode() : $treeBuilder->root('stof_doctrine_extensions');

@odolbeau
Copy link
Author

odolbeau commented Dec 9, 2018

@matthieumota: updated!

Copy link

@garethbraid89 garethbraid89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed a couple of variable names to make sure they match older ones

DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
Co-Authored-By: odolbeau <github@a.bbnt.me>
@odolbeau
Copy link
Author

I didn't pay attention to that, thanks @garethbraid89!

@franmomu
Copy link
Contributor

This bundle supports "php": ">=5.3.2" so TreeBuilder::class cannot be used because was introduced in PHP 5.5.0. So I would use doctrine/DoctrineBundle#853 approach.

@matthieumota
Copy link

Okay so @odolbeau just need to pass treebuilder instance rather than FQN instruction.

@stof
Copy link
Owner

stof commented Jan 14, 2019

Actually closing because #388 also fixed it.

@stof stof closed this Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants