New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid deprecated notice when using symfony/config > 4.2 #383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I purpose a more concise syntax
$rootNode = \method_exists(TreeBuilder::class, 'getRootNode') ? $treeBuilder->getRootNode() : $treeBuilder->root('stof_doctrine_extensions');
f35c161
to
8d8b6ad
Compare
@matthieumota: updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed a couple of variable names to make sure they match older ones
Co-Authored-By: odolbeau <github@a.bbnt.me>
I didn't pay attention to that, thanks @garethbraid89! |
This bundle supports |
Okay so @odolbeau just need to pass treebuilder instance rather than FQN instruction. |
327e61f
to
6b5e25c
Compare
Actually closing because #388 also fixed it. |
See: https://github.com/symfony/symfony/blob/master/UPGRADE-4.2.md#config