Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump all deps except smoltcp #426

Merged
merged 4 commits into from
Mar 22, 2023
Merged

bump all deps except smoltcp #426

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d169af6
bump all deps except smoltcp
olback Mar 13, 2023
c03b667
remove unit let binding
olback Mar 15, 2023
5a61604
fix semihosting examples
olback Mar 15, 2023
80948ac
make clippy happy
olback Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ rustdoc-args = ["--cfg", "docsrs"]
fugit = "0.3.5"
embedded-hal = { version = "0.2.6", features = ["unproven"] }
embedded-dma = "0.2.0"
cortex-m = "^0.7.4"
cortex-m = { version = "^0.7.7", features = ["critical-section-single-core"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the feature only be enabled on the single core variants?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be in over my head here...

From what I've managed to figure out is:

  • cortex_m::interrupt::free is unsound(?)
  • critical_section::with is not unsound but needs to be implemented by either this crate or use the "default" provided by the critical-section-single-core feature in cortex-m

rust-embedded/cortex-m#448

https://github.com/rust-embedded/cortex-m/blob/master/CHANGELOG.md states that

So to answer your question: Probably, in the future when this crate supports multiple cores. As long as we don't provide any way to run code on multiple cores in this crate, using the feature critical-section-single-core should be fine(?).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating this @olback ! I'm ok with this solution for now since there's no explicit support for multiple cores yet. It's even possible a HAL isn't actually the right place to implement multicore support, but I think that is still uncertain.

defmt = { version = ">=0.2.0,<0.4", optional = true }
stm32h7 = { version = "^0.15.1", default-features = false }
void = { version = "1.0.2", default-features = false }
Expand All @@ -45,7 +45,7 @@ synopsys-usb-otg = { version = "^0.3.0", features = ["cortex-m"], optional = tru
embedded-display-controller = { version = "^0.1.0", optional = true }
log = { version = "0.4.14", optional = true} # see also the dev-dependencies section
fdcan = { version = "0.1", optional = true }
bitflags = { version = "1.3.2" }
bitflags = { version = "2.0.0" }
embedded-storage = "0.3"

[dependencies.smoltcp]
Expand All @@ -71,10 +71,10 @@ log = "0.4.11"
panic-halt = "0.2.0"
panic-rtt-target = { version = "0.1.0", features = ["cortex-m"] }
cfg-if = "1.0.0"
rtt-target = { version = "0.3.1", features = ["cortex-m"] }
rtt-target = "0.4.0"
lazy_static = { version = "1.4.0", features = ["spin_no_std"] }
cortex-m-log = { version = "~0.7.0", features = ["itm", "semihosting", "log-integration"] }
cortex-m-semihosting = "0.3.5"
cortex-m-log = { version = "0.8.0", features = ["itm", "semihosting", "log-integration"] }
cortex-m-semihosting = "0.5.0"
panic-itm = { version = "~0.4.1" }
panic-semihosting = "0.6"
usb-device = "0.2.5"
Expand Down