bump all deps except smoltcp #426

olback · 2023-03-13T21:52:58Z

cargo outdated

Name     Project  Compat  Latest  Kind    Platform
----     -------  ------  ------  ----    --------
smoltcp  0.8.2    ---     0.9.1   Normal  ---

cargo duplicates

Package        Versions
-------        --------
bare-metal     1.0.0   0.2.5
bitflags       2.0.0   1.3.2
nb             1.1.0   0.1.3
rtt-target     0.4.0   0.3.1
rustc_version  0.4.0   0.2.3
semver         1.0.17  0.9.0
spin           0.9.6   0.5.2

bare-metal 1.0.0:
- Because of stm32h7xx-hal 0.13.1 => cortex-m-rtic 1.1.4 => bare-metal 1.0.0
- Because of stm32h7xx-hal 0.13.1 => stm32h7 0.15.1 => bare-metal 1.0.0
- Because of stm32h7xx-hal 0.13.1 => bare-metal 1.0.0
bare-metal 0.2.5:
- Because of stm32h7xx-hal 0.13.1 => cortex-m-log 0.8.0 => cortex-m 0.7.7 => bare-metal 0.2.5
- Because of stm32h7xx-hal 0.13.1 => cortex-m-rtic 1.1.4 => cortex-m 0.7.7 => bare-metal 0.2.5
- Because of stm32h7xx-hal 0.13.1 => cortex-m-log 0.8.0 => cortex-m-semihosting 0.5.0 => cortex-m 0.7.7 => bare-metal 0.2.5
- Because of stm32h7xx-hal 0.13.1 => panic-semihosting 0.6.0 => cortex-m-semihosting 0.5.0 => cortex-m 0.7.7 => bare-metal 0.2.5
- Because of stm32h7xx-hal 0.13.1 => cortex-m-semihosting 0.5.0 => cortex-m 0.7.7 => bare-metal 0.2.5
- Because of stm32h7xx-hal 0.13.1 => panic-itm 0.4.2 => cortex-m 0.7.7 => bare-metal 0.2.5
- Because of stm32h7xx-hal 0.13.1 => panic-rtt-target 0.1.2 => cortex-m 0.7.7 => bare-metal 0.2.5
- Because of stm32h7xx-hal 0.13.1 => panic-semihosting 0.6.0 => cortex-m 0.7.7 => bare-metal 0.2.5
- Because of stm32h7xx-hal 0.13.1 => stm32h7 0.15.1 => cortex-m 0.7.7 => bare-metal 0.2.5
- Because of stm32h7xx-hal 0.13.1 => cortex-m 0.7.7 => bare-metal 0.2.5
- Because of stm32h7xx-hal 0.13.1 => synopsys-usb-otg 0.3.2 => cortex-m 0.7.7 => bare-metal 0.2.5

bitflags 2.0.0:
- Because of stm32h7xx-hal 0.13.1 => bitflags 2.0.0
bitflags 1.3.2:
- Because of stm32h7xx-hal 0.13.1 => defmt 0.3.2 => bitflags 1.3.2
- Because of stm32h7xx-hal 0.13.1 => fdcan 0.1.2 => bitflags 1.3.2
- Because of stm32h7xx-hal 0.13.1 => smoltcp 0.8.2 => bitflags 1.3.2

nb 1.1.0:
- Because of stm32h7xx-hal 0.13.1 => fdcan 0.1.2 => nb 1.1.0
- Because of stm32h7xx-hal 0.13.1 => cortex-m-log 0.8.0 => cortex-m 0.7.7 => embedded-hal 0.2.7 => nb 0.1.3 => nb 1.1.0
- Because of stm32h7xx-hal 0.13.1 => cortex-m-rtic 1.1.4 => cortex-m 0.7.7 => embedded-hal 0.2.7 => nb 0.1.3 => nb 1.1.0
- Because of stm32h7xx-hal 0.13.1 => cortex-m-log 0.8.0 => cortex-m-semihosting 0.5.0 => cortex-m 0.7.7 => embedded-hal 0.2.7 => nb 0.1.3 => nb 1.1.0
- Because of stm32h7xx-hal 0.13.1 => panic-semihosting 0.6.0 => cortex-m-semihosting 0.5.0 => cortex-m 0.7.7 => embedded-hal 0.2.7 => nb 0.1.3 => nb 1.1.0
- Because of stm32h7xx-hal 0.13.1 => cortex-m-semihosting 0.5.0 => cortex-m 0.7.7 => embedded-hal 0.2.7 => nb 0.1.3 => nb 1.1.0
- Because of stm32h7xx-hal 0.13.1 => panic-itm 0.4.2 => cortex-m 0.7.7 => embedded-hal 0.2.7 => nb 0.1.3 => nb 1.1.0
- Because of stm32h7xx-hal 0.13.1 => panic-rtt-target 0.1.2 => cortex-m 0.7.7 => embedded-hal 0.2.7 => nb 0.1.3 => nb 1.1.0
- Because of stm32h7xx-hal 0.13.1 => panic-semihosting 0.6.0 => cortex-m 0.7.7 => embedded-hal 0.2.7 => nb 0.1.3 => nb 1.1.0
- Because of stm32h7xx-hal 0.13.1 => stm32h7 0.15.1 => cortex-m 0.7.7 => embedded-hal 0.2.7 => nb 0.1.3 => nb 1.1.0
- Because of stm32h7xx-hal 0.13.1 => cortex-m 0.7.7 => embedded-hal 0.2.7 => nb 0.1.3 => nb 1.1.0
- Because of stm32h7xx-hal 0.13.1 => synopsys-usb-otg 0.3.2 => cortex-m 0.7.7 => embedded-hal 0.2.7 => nb 0.1.3 => nb 1.1.0
- Because of stm32h7xx-hal 0.13.1 => embedded-sdmmc 0.4.0 => embedded-hal 0.2.7 => nb 0.1.3 => nb 1.1.0
- Because of stm32h7xx-hal 0.13.1 => stm32-fmc 0.3.0 => embedded-hal 0.2.7 => nb 0.1.3 => nb 1.1.0
- Because of stm32h7xx-hal 0.13.1 => embedded-hal 0.2.7 => nb 0.1.3 => nb 1.1.0
- Because of stm32h7xx-hal 0.13.1 => synopsys-usb-otg 0.3.2 => embedded-hal 0.2.7 => nb 0.1.3 => nb 1.1.0
- Because of stm32h7xx-hal 0.13.1 => usbd-serial 0.1.1 => embedded-hal 0.2.7 => nb 0.1.3 => nb 1.1.0
- Because of stm32h7xx-hal 0.13.1 => usbd-serial 0.1.1 => nb 0.1.3 => nb 1.1.0
- Because of stm32h7xx-hal 0.13.1 => nb 1.1.0
nb 0.1.3:
- Because of stm32h7xx-hal 0.13.1 => cortex-m-log 0.8.0 => cortex-m 0.7.7 => embedded-hal 0.2.7 => nb 0.1.3
- Because of stm32h7xx-hal 0.13.1 => cortex-m-rtic 1.1.4 => cortex-m 0.7.7 => embedded-hal 0.2.7 => nb 0.1.3
- Because of stm32h7xx-hal 0.13.1 => cortex-m-log 0.8.0 => cortex-m-semihosting 0.5.0 => cortex-m 0.7.7 => embedded-hal 0.2.7 => nb 0.1.3
- Because of stm32h7xx-hal 0.13.1 => panic-semihosting 0.6.0 => cortex-m-semihosting 0.5.0 => cortex-m 0.7.7 => embedded-hal 0.2.7 => nb 0.1.3
- Because of stm32h7xx-hal 0.13.1 => cortex-m-semihosting 0.5.0 => cortex-m 0.7.7 => embedded-hal 0.2.7 => nb 0.1.3
- Because of stm32h7xx-hal 0.13.1 => panic-itm 0.4.2 => cortex-m 0.7.7 => embedded-hal 0.2.7 => nb 0.1.3
- Because of stm32h7xx-hal 0.13.1 => panic-rtt-target 0.1.2 => cortex-m 0.7.7 => embedded-hal 0.2.7 => nb 0.1.3
- Because of stm32h7xx-hal 0.13.1 => panic-semihosting 0.6.0 => cortex-m 0.7.7 => embedded-hal 0.2.7 => nb 0.1.3
- Because of stm32h7xx-hal 0.13.1 => stm32h7 0.15.1 => cortex-m 0.7.7 => embedded-hal 0.2.7 => nb 0.1.3
- Because of stm32h7xx-hal 0.13.1 => cortex-m 0.7.7 => embedded-hal 0.2.7 => nb 0.1.3
- Because of stm32h7xx-hal 0.13.1 => synopsys-usb-otg 0.3.2 => cortex-m 0.7.7 => embedded-hal 0.2.7 => nb 0.1.3
- Because of stm32h7xx-hal 0.13.1 => embedded-sdmmc 0.4.0 => embedded-hal 0.2.7 => nb 0.1.3
- Because of stm32h7xx-hal 0.13.1 => stm32-fmc 0.3.0 => embedded-hal 0.2.7 => nb 0.1.3
- Because of stm32h7xx-hal 0.13.1 => embedded-hal 0.2.7 => nb 0.1.3
- Because of stm32h7xx-hal 0.13.1 => synopsys-usb-otg 0.3.2 => embedded-hal 0.2.7 => nb 0.1.3
- Because of stm32h7xx-hal 0.13.1 => usbd-serial 0.1.1 => embedded-hal 0.2.7 => nb 0.1.3
- Because of stm32h7xx-hal 0.13.1 => usbd-serial 0.1.1 => nb 0.1.3

rtt-target 0.4.0:
- Because of stm32h7xx-hal 0.13.1 => rtt-target 0.4.0
rtt-target 0.3.1:
- Because of stm32h7xx-hal 0.13.1 => panic-rtt-target 0.1.2 => rtt-target 0.3.1

rustc_version 0.4.0:
- Because of stm32h7xx-hal 0.13.1 => cortex-m-rtic 1.1.4 => heapless 0.7.16 => rustc_version 0.4.0
rustc_version 0.2.3:
- Because of stm32h7xx-hal 0.13.1 => cortex-m-log 0.8.0 => cortex-m 0.7.7 => bare-metal 0.2.5 => rustc_version 0.2.3
- Because of stm32h7xx-hal 0.13.1 => cortex-m-rtic 1.1.4 => cortex-m 0.7.7 => bare-metal 0.2.5 => rustc_version 0.2.3
- Because of stm32h7xx-hal 0.13.1 => cortex-m-log 0.8.0 => cortex-m-semihosting 0.5.0 => cortex-m 0.7.7 => bare-metal 0.2.5 => rustc_version 0.2.3
- Because of stm32h7xx-hal 0.13.1 => panic-semihosting 0.6.0 => cortex-m-semihosting 0.5.0 => cortex-m 0.7.7 => bare-metal 0.2.5 => rustc_version 0.2.3
- Because of stm32h7xx-hal 0.13.1 => cortex-m-semihosting 0.5.0 => cortex-m 0.7.7 => bare-metal 0.2.5 => rustc_version 0.2.3
- Because of stm32h7xx-hal 0.13.1 => panic-itm 0.4.2 => cortex-m 0.7.7 => bare-metal 0.2.5 => rustc_version 0.2.3
- Because of stm32h7xx-hal 0.13.1 => panic-rtt-target 0.1.2 => cortex-m 0.7.7 => bare-metal 0.2.5 => rustc_version 0.2.3
- Because of stm32h7xx-hal 0.13.1 => panic-semihosting 0.6.0 => cortex-m 0.7.7 => bare-metal 0.2.5 => rustc_version 0.2.3
- Because of stm32h7xx-hal 0.13.1 => stm32h7 0.15.1 => cortex-m 0.7.7 => bare-metal 0.2.5 => rustc_version 0.2.3
- Because of stm32h7xx-hal 0.13.1 => cortex-m 0.7.7 => bare-metal 0.2.5 => rustc_version 0.2.3
- Because of stm32h7xx-hal 0.13.1 => synopsys-usb-otg 0.3.2 => cortex-m 0.7.7 => bare-metal 0.2.5 => rustc_version 0.2.3

semver 1.0.17:
- Because of stm32h7xx-hal 0.13.1 => cortex-m-rtic 1.1.4 => heapless 0.7.16 => rustc_version 0.4.0 => semver 1.0.17
semver 0.9.0:
- Because of stm32h7xx-hal 0.13.1 => cortex-m-log 0.8.0 => cortex-m 0.7.7 => bare-metal 0.2.5 => rustc_version 0.2.3 => semver 0.9.0
- Because of stm32h7xx-hal 0.13.1 => cortex-m-rtic 1.1.4 => cortex-m 0.7.7 => bare-metal 0.2.5 => rustc_version 0.2.3 => semver 0.9.0
- Because of stm32h7xx-hal 0.13.1 => cortex-m-log 0.8.0 => cortex-m-semihosting 0.5.0 => cortex-m 0.7.7 => bare-metal 0.2.5 => rustc_version 0.2.3 => semver 0.9.0
- Because of stm32h7xx-hal 0.13.1 => panic-semihosting 0.6.0 => cortex-m-semihosting 0.5.0 => cortex-m 0.7.7 => bare-metal 0.2.5 => rustc_version 0.2.3 => semver 0.9.0
- Because of stm32h7xx-hal 0.13.1 => cortex-m-semihosting 0.5.0 => cortex-m 0.7.7 => bare-metal 0.2.5 => rustc_version 0.2.3 => semver 0.9.0
- Because of stm32h7xx-hal 0.13.1 => panic-itm 0.4.2 => cortex-m 0.7.7 => bare-metal 0.2.5 => rustc_version 0.2.3 => semver 0.9.0
- Because of stm32h7xx-hal 0.13.1 => panic-rtt-target 0.1.2 => cortex-m 0.7.7 => bare-metal 0.2.5 => rustc_version 0.2.3 => semver 0.9.0
- Because of stm32h7xx-hal 0.13.1 => panic-semihosting 0.6.0 => cortex-m 0.7.7 => bare-metal 0.2.5 => rustc_version 0.2.3 => semver 0.9.0
- Because of stm32h7xx-hal 0.13.1 => stm32h7 0.15.1 => cortex-m 0.7.7 => bare-metal 0.2.5 => rustc_version 0.2.3 => semver 0.9.0
- Because of stm32h7xx-hal 0.13.1 => cortex-m 0.7.7 => bare-metal 0.2.5 => rustc_version 0.2.3 => semver 0.9.0
- Because of stm32h7xx-hal 0.13.1 => synopsys-usb-otg 0.3.2 => cortex-m 0.7.7 => bare-metal 0.2.5 => rustc_version 0.2.3 => semver 0.9.0

spin 0.9.6:
- Because of stm32h7xx-hal 0.13.1 => cortex-m-rtic 1.1.4 => heapless 0.7.16 => spin 0.9.6
spin 0.5.2:
- Because of stm32h7xx-hal 0.13.1 => lazy_static 1.4.0 => spin 0.5.2

olback · 2023-03-13T21:58:01Z

While I'm at it, we should probably update the CI script as well:

Warning: The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Edit: The warning comes from actions-rs/toolchain. That whole org has not received any updates for about 3 years. Could this be an alternative?

mattico · 2023-03-13T22:29:01Z

Cargo.toml

@@ -30,7 +30,7 @@ rustdoc-args = ["--cfg", "docsrs"]
 fugit = "0.3.5"
 embedded-hal = { version = "0.2.6", features = ["unproven"] }
 embedded-dma = "0.2.0"
-cortex-m = "^0.7.4"
+cortex-m = { version = "^0.7.7", features = ["critical-section-single-core"] }


Should the feature only be enabled on the single core variants?

I might be in over my head here...

From what I've managed to figure out is:

cortex_m::interrupt::free is unsound(?)

critical_section::with is not unsound but needs to be implemented by either this crate or use the "default" provided by the critical-section-single-core feature in cortex-m

rust-embedded/cortex-m#448

https://github.com/rust-embedded/cortex-m/blob/master/CHANGELOG.md states that

Added critical-section-single-core feature which provides an implementation for the critical_section crate for single-core systems, based on disabling all interrupts. (Change incorrect link from I2C to I2S in mod.rs #447)

interrupt::free no longer hands out a CriticalSection token because it is unsound on multi-core. Use critical_section::with instead. (Change incorrect link from I2C to I2S in mod.rs #447)

So to answer your question: Probably, in the future when this crate supports multiple cores. As long as we don't provide any way to run code on multiple cores in this crate, using the feature critical-section-single-core should be fine(?).

Thanks for investigating this @olback ! I'm ok with this solution for now since there's no explicit support for multiple cores yet. It's even possible a HAL isn't actually the right place to implement multicore support, but I think that is still uncertain.

richardeoin

Overall looks good to me 👍 It looks like this actually gets us some extra duplicates (for example bitflags v2.0, whilst our dependencies are still using v1.x) but that they will presumably upgrade too in future.

richardeoin · 2023-03-22T19:45:01Z

bors r+

bors · 2023-03-22T19:53:12Z

Build succeeded:

bump all deps except smoltcp

d169af6

olback marked this pull request as draft March 13, 2023 21:53

mattico reviewed Mar 13, 2023

View reviewed changes

olback added 3 commits March 15, 2023 19:04

remove unit let binding

c03b667

fix semihosting examples

5a61604

make clippy happy

80948ac

olback marked this pull request as ready for review March 15, 2023 20:42

olback changed the title ~~Draft: bump all deps except smoltcp~~ bump all deps except smoltcp Mar 15, 2023

richardeoin approved these changes Mar 19, 2023

View reviewed changes

bors bot merged commit 41f30d6 into stm32-rs:master Mar 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump all deps except smoltcp #426

bump all deps except smoltcp #426

olback commented Mar 13, 2023

olback commented Mar 13, 2023 •

edited

mattico Mar 13, 2023

olback Mar 15, 2023

richardeoin Mar 19, 2023

richardeoin left a comment

richardeoin commented Mar 22, 2023

bors bot commented Mar 22, 2023

bump all deps except smoltcp #426

bump all deps except smoltcp #426

Conversation

olback commented Mar 13, 2023

olback commented Mar 13, 2023 • edited

mattico Mar 13, 2023

Choose a reason for hiding this comment

olback Mar 15, 2023

Choose a reason for hiding this comment

richardeoin Mar 19, 2023

Choose a reason for hiding this comment

richardeoin left a comment

Choose a reason for hiding this comment

richardeoin commented Mar 22, 2023

bors bot commented Mar 22, 2023

olback commented Mar 13, 2023 •

edited