Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook v7 compatibility - and dependency updates #17

Closed
wants to merge 33 commits into from
Closed

Storybook v7 compatibility - and dependency updates #17

wants to merge 33 commits into from

Conversation

meza
Copy link

@meza meza commented Mar 6, 2023

I've made the changes necessary for this to work with Storybook v7

It also contains the suggested fix from #15

Note I've published the package as @meza/storybook-react-i18next to test it and to use it until this gets merged.

I've also ran prettier it seems like it hasn't been applied in a while.

@stevensacks
Copy link
Owner

Thanks for this! I will review. If it isn’t backwards compatible with Storybook 6, I think we need to bump the major version to 2.

sawyerh added a commit to navapbc/template-application-nextjs that referenced this pull request Mar 17, 2023
## Ticket

Relates to #121

## Changes

- Upgraded to latest i18next dependencies

## Context for reviewers

Some of the i18next devDependencies updates are dependent on
stevensacks/storybook-react-i18next#17
@JReinhold
Copy link

Hey @meza and @stevensacks, Storybook v7.0.0 is out! It's only on the next tag for now, but it's still targetable with the ^7.0.0 semver range, so you should be able to develop against it with no dependency issues.

If you hit any issues with v7, we've written a migration guide for addon authors here and here.

You're also free to reach out to us in the #prerelease channel on our Discord Server and we'll happily help you out!

cc @ndelangen

@stevensacks
Copy link
Owner

I’ll be merging this in soon. Just working through a couple of issues.

@dohomi
Copy link

dohomi commented Apr 3, 2023

great looking forward for this to be released! Thanks for your work on this addon

@Woodii1998
Copy link

I'm looking forward to the compatibility with storybook 7! When is the official release expected?

@stevensacks
Copy link
Owner

I fixed this more completely in a different PR.

@stevensacks stevensacks closed this Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants