Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove storybook-react-i18next #121

Closed
sawyerh opened this issue Mar 3, 2023 · 3 comments
Closed

Remove storybook-react-i18next #121

sawyerh opened this issue Mar 3, 2023 · 3 comments

Comments

@sawyerh
Copy link
Contributor

sawyerh commented Mar 3, 2023

Unfortunately, it doesn't seem like storybook-react-i18next is maintained any longer. The impact of that is:

  1. We're blocked from updating other i18next dependencies: Update dependency next-i18next to v13 #92
  2. We're blocked from updating to the next major release of Storybook: Any plans to support storybook 7 stevensacks/storybook-react-i18next#16

Additional context

I opened stevensacks/storybook-react-i18next#15 in December 2022 but haven't gotten any engagement.

Related issue:

Potential next steps

  • Uninstall storybook-react-i18next, replacing it with another way to enable support for internationalization in Storybook.
  • We could start simple, and only render English previews in Storybook.
  • A follow-up could add a language toggle

🚨 We should target Storybook v7 for these changes, since one of the primary goals is to unblock an upgrade to that version.

References

@sawyerh
Copy link
Contributor Author

sawyerh commented Mar 17, 2023

It looks like there's been movement on this package and we may get lucky, and not have to remove it. My PR just got merged, and someone has opened a PR to support Storybook 7: stevensacks/storybook-react-i18next#17

sawyerh added a commit that referenced this issue Mar 17, 2023
## Ticket

Relates to #121

## Changes

- Upgraded to latest i18next dependencies

## Context for reviewers

Some of the i18next devDependencies updates are dependent on
stevensacks/storybook-react-i18next#17
@stevensacks
Copy link

I'm doing SB7 compat today.

@sawyerh
Copy link
Contributor Author

sawyerh commented Apr 7, 2023

@stevensacks Thank you! I hope you're doing well.

@sawyerh sawyerh closed this as completed Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants