Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transaction hash field to each item in the getEvents response #939

Merged
merged 3 commits into from Apr 26, 2024
Merged

Add transaction hash field to each item in the getEvents response #939

merged 3 commits into from Apr 26, 2024

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Apr 18, 2024

Closes #938

@Shaptic Shaptic mentioned this pull request Apr 18, 2024
Closed
@Shaptic Shaptic changed the title Add txHash field to getEvents response items Add transaction hash field to each item in the getEvents response Apr 18, 2024
@github-actions GitHub Actions
Copy link

Size Change: +56 B (0%)

Total Size: 11.4 MB

Filename Size Change
dist/stellar-sdk.js 6.34 MB +28 B (0%)
dist/stellar-sdk.min.js 5.1 MB +28 B (0%)

compressed-size-action

@Shaptic Shaptic mentioned this pull request Apr 25, 2024
Closed
2 tasks
sreuland
sreuland approved these changes Apr 26, 2024
View reviewed changes
Copy link

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, left one question for consideration on whether tx hash field should be optional

@Shaptic Shaptic merged commit 34ccf20 into master Apr 26, 2024
10 checks passed
@Shaptic Shaptic deleted the addTxHash-getEvents branch April 26, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreuland sreuland sreuland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing txHash field in EventResponse type
2 participants
@Shaptic @sreuland