Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing txHash field in EventResponse type #938

Closed
faramozzayw opened this issue Apr 18, 2024 · 1 comment · Fixed by #939
Closed

Missing txHash field in EventResponse type #938

faramozzayw opened this issue Apr 18, 2024 · 1 comment · Fixed by #939
Assignees
Labels

Comments

@faramozzayw
Copy link

Describe the bug

The EventResponse type is missing a txHash field, which is included in the RPC response.

@Shaptic
Copy link
Contributor

Shaptic commented Apr 18, 2024

Hm, you're right, even though this isn't described in the getEvents API reference.. I've opened #939 to resolve this; thanks for the report!

@Shaptic Shaptic self-assigned this Apr 18, 2024
Shaptic added a commit to stellar/stellar-docs that referenced this issue Apr 18, 2024
ElliotFriend added a commit to stellar/stellar-docs that referenced this issue Apr 19, 2024
…s` response (#507)

* Add txHash field to getEvents response items:

See stellar/js-stellar-sdk#938.

* Reference the hash schema rather than a basic string

* Reference it as a transactionhash explicitly

* update events examples to include txHash field

* change events response field to a string, rather than object

---------

Co-authored-by: Elliot Voris <elliot@stellar.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants