Allow Symfony4 #79
Allow Symfony4 #79
Conversation
composer.json
Outdated
| @@ -8,12 +8,13 @@ | |||
| "email": "stephen@stecman.co.nz" | |||
| } | |||
| ], | |||
| "minimum-stability": "beta", | |||
There was a problem hiding this comment.
This won't have any effect, because it's read only from master composer.json of your project and not the dependency library composer.json files.
composer.json
Outdated
| }, | ||
| "require-dev": { | ||
| "phpunit/phpunit": "~4.4" | ||
| "phpunit/phpunit": "~4.4 || ~5.7" |
There was a problem hiding this comment.
Let's add PHPUnit 6.x here as well.
There was a problem hiding this comment.
Added, but note that 4.x & 6.x are incompatible and 6.x not supports \PHPUnit_Framework_TestCase, you should use \PHPUnit\Framework\TestCase at least in your tests. 5.7 supports both FQCN cases
There was a problem hiding this comment.
Ah, then please (if possible) send a separate PR where you replaces \PHPUnit_Framework_TestCase with TestCase + use PHPUnit\Framework\TestCase;.
|
Rewrited tests for use PHPUnit in 6.x style. Tested with 4.8, 5.7 and 6.4 |
VolCh
changed the title
| if ($status !== 0) { | ||
| $this->fail("Syntax check for $context failed:\n$output"); | ||
| } | ||
| $this->assertEquals(0, $status, "Syntax check for $context failed:\n$output"); |
There was a problem hiding this comment.
That's not equivalent construct, because assertEquals doesn't do === internally. Use assertSame instead.
|
Tests are failing PHP 5.5, because PHPUnit version on Travis CI isn't the one with support of |
VolCh
force-pushed
the
symfony4
branch
2 times, most recently
from
178b399
to
e0fc0af
Compare
|
I set the lowest PHPUnit version to 4.8.36 that introduced forward compatible layer. |
|
#81 - there used the phpunit from require-devs composer section. |
|
Need some more steps on my part to release changes? Or are we waiting for a stable Symfony 4 version? |
|
@stecman , any updates? |
|
@stecman ping? ;) |
|
@stecman pretty please? |
.travis.yml
Outdated
| @@ -2,13 +2,15 @@ language: php | |||
|
|
|||
| matrix: | |||
| include: | |||
| - php: 5.3 | |||
There was a problem hiding this comment.
Instead add dist: precise so that PHP 5.3 build can work.
5.3 supported by Travis CI now in precise only 7.2 is RC 7.3 is nightly HVVM is 5.6 based and I think that -prefer-lowest is enough nowadays
|
@aik099 thanks for advice: restored 5.3. Also added 7.3 (nightly) with allow failures |
|
Thanks @VolCh . |
|
Since Symfony 4 was released November 30th, are we going to see this merged in? |
|
+1 |
|
any chance to get this released as a semver tag? :) thanks |
This PR add support symfony-console-completion in projects that use console 4.0.0-BETA1 and(or) PHPUnit 5.7.
It seems safe to add "minimum-stability": "beta" in master, after release it should be removed. Or you can pull the PR in separate branch to use for example
"stecman/symfony-console-completion": "dev-symfony4"in composer.json for testing projects with beta without add forking repo to composer.json