Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 4 components #4580

Merged
merged 4 commits into from Nov 23, 2017
Merged

Allow Symfony 4 components #4580

merged 4 commits into from Nov 23, 2017

Conversation

VolCh
Copy link
Contributor

@VolCh VolCh commented Oct 21, 2017

I am starting to work on support of Symfony 4.0.0-BETA1

@VolCh
Copy link
Contributor Author

VolCh commented Oct 22, 2017

Added my repos with PRs:
php-webdriver/php-webdriver#489
stecman/symfony-console-completion#79
sebastianbergmann/phpunit#2822 (already merged, repo removed)

Installed symfony components are:

$composer info symfony/*
symfony/browser-kit       v4.0.0-BETA1 Symfony BrowserKit Component
symfony/console           v4.0.0-BETA1 Symfony Console Component
symfony/css-selector      v4.0.0-BETA1 Symfony CssSelector Component
symfony/debug             v4.0.0-BETA1 Symfony Debug Component
symfony/dom-crawler       v4.0.0-BETA1 Symfony DomCrawler Component
symfony/event-dispatcher  v4.0.0-BETA1 Symfony EventDispatcher Component
symfony/finder            v4.0.0-BETA1 Symfony Finder Component
symfony/polyfill-mbstring v1.6.0       Symfony polyfill for the Mbstring extension
symfony/process           v4.0.0-BETA1 Symfony Process Component
symfony/yaml              v4.0.0-BETA1 Symfony Yaml Component

Feel to free run any tests

@DavertMik
Copy link
Member

DavertMik commented Oct 22, 2017

Great! However I need to add some guides for this process.

Dockerfile is not used for testing. What you actually need is to setup .travis.yml. We already have similar setup for Symfony 2 and 3 so you can just add one more element to the matrix to run Symfony4 tests. https://github.com/Codeception/Codeception/blob/2.3/.travis.yml#L17

Please change minimal requirements for composer.json but change them dynamically in Travis
https://github.com/Codeception/Codeception/blob/2.3/.travis.yml#L46

@VolCh
Copy link
Contributor Author

VolCh commented Nov 15, 2017

Current status:

Waiting merge & tag PR stecman/symfony-console-completion#79
Waiting merge (at least) PR symfony/symfony#24975 causes TypeError in tests
Investigating other tests failures & symfony/symfony:4.0.0 composer conflict

@DavertMik
Copy link
Member

Ok, we have only one blocker:

stecman/symfony-console-completion#79

If we don't see it merged in few next days we can remove it from required dependencies and allow it to be installed optionally. This feature is not that important... But we need to keep it going

@VolCh VolCh force-pushed the symfony4 branch 7 times, most recently from 66273aa to 015b124 Compare November 21, 2017 20:44
@mariusbalcytis
Copy link

Few days have passed - should we still wait? Unfortunately this cascades to other libraries and projects - they cannot be updated for sf4, as their tests cannot pass (if they are written in codeception). Thus other libraries and projects cannot be updated and so on.

@DavertMik
Copy link
Member

DavertMik commented Nov 22, 2017

Few days have passed - should we still wait? Unfortunately this cascades to other libraries and projects - they cannot be updated for sf4, as their tests cannot pass (if they are written in codeception). Thus other libraries and projects cannot be updated and so on.

Recursion! Yes, I think it can be merged.
But before the release I'd detach symfony autocompletion package as it is not updateding...

@VolCh is it ready?

@@ -43,7 +43,6 @@ public function runTestWithDataProvidersFailureStdout(\CliGuy $I)
public function runTestWithDataProvidersFailureStderr(\CliGuy $I)
{
$I->executeCommand('run -n unit DataProvidersFailureCest 2>&1',false);
$I->seeInShellOutput('[Codeception\Exception\TestParseException]');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove some assertions from this test?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format of output in Symfony Console has changed

@VolCh VolCh changed the title [WIP] Start support of Symfony4 Allow Symfony 4 components Nov 23, 2017
@VolCh
Copy link
Contributor Author

VolCh commented Nov 23, 2017

Added fallback for absent stecman/symfony-console-completion

Rebased and splitted to atomic commits.

I think it ready to work in Symfony 4 environment. Needs some CI changes after Symfony 4 release.

Full support of Symfony 4 framework (its DI container first of all) I am planing check & implement at weekend in another PR.

@DavertMik
Copy link
Member

Thank you!

@DavertMik DavertMik merged commit 08c717d into Codeception:2.3 Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants