object-curly-spacing

[eddiemoore]

Require a space at the start and end of objects.
Valid:

var obj = {};
var obj = { 'foo': 'bar' };
var obj = { 'foo': { 'bar': 'baz' }, 'qux': 'quxx' };
var obj = {
  'foo': 'bar'
};
var { x } = y;
import { foo } from 'bar';

Invalid

var obj = {'foo': 'bar'};
var obj = {'foo': 'bar' };
var obj = { baz: {'foo': 'qux'}, bar};
var obj = {baz: { 'foo': 'qux' }, bar};
var obj = {'foo': 'bar'
};
var obj = {
  'foo':'bar'};
var {x} = y;
import {foo } from 'bar';

[julien-f]

What about arrays?
Shouldn't it have the same behavior?

[julien-f]

And this is a major change, standard would be bumped to v6.

[dcousens]

AFAIK this is already meant to be enforced, if this isn't the case, it's a bug IIRC.

[dcousens]

Reference standard/standard#182, this is out lined as what we expected.

@feross looks good to me? Merge?

[eddiemoore]

I know there is the even spacing rule at the moment, however it can mean that you aren't consistent across all objects in all files.

var x = { y: 42 }
var z = {p: 24}

This for example, would be valid at the moment. I just feel that it should be consistent spacing across everything.

[dcousens]

Ah, that is the key point of difference.

[feross]

Yeah, this is a big breaking change. We investigated how easy it would be to make things consistent across a single file, but it wasn't easy.

In the future, I'm hoping we can just pick var x = { y: 42 } as the correct style, but we need to think about the implications of breakage.

[dcousens]

@feross where were those stats again?
Any chance we can see where they sit now for a rule change such as this?

[feross]

I ran it a while ago. I can re-run, but I know it's going to be too high (double digit percentages) to get into standard v6. I think we should punt until v7, or this release is going to get too huge.

[mightyiam]

Continue conversation @ Object curlies: File/project–wide or standard?