New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
standard-strict #382
Comments
What is wrong with that? |
Because that will raise an error in strict mode. |
I like the idea, but I would keep |
yeah, we should avoid having options. @rstacruz have you raised those rules to be considered in individual issues? I'm not familiar with all of them, but perhaps they'd be a good addition. |
aye, a separate package makes sense. they were /sorta/ discussed in #216, with an exhaustive list of differences from xo here: #216 (comment) nonetheless, i think it makes sense to do it in a separate package at first (think of it as "standard-staging"), and we can eventually migrate rules into upstream standard. It really is no big deal to build it as a separate package, it's basically: /* eslintrc */
{
"extends": [ "standard", "standard-react", "standard-strict" ]
} |
Awkward... |
nice one denis! |
@dcousens @feross any thoughts on those additional rules? |
Not completely against this idea. Need to think about it more. |
Here's another rule that would make sense for a stricter mode: #381 |
Another rule: standard/eslint-config-standard#21 |
Perhaps Make it the bleeding-edge of what can be expected in the next major version of |
Maybe |
One more rule: standard/eslint-config-standard#19 |
https://github.com/denis-sokolov/strict-standard @denis-sokolov did some fine work on this. |
@dcousens @feross Are you familiar with codemods? There's a Facebook library jscodeshift that lets you apply AST transformations to JS code, instead of doing text transformations. It may be worth considering writing a few transforms for breaking changes. Even if they don't catch all the cases, it makes it much easier for people to upgrade their projects. |
@cesarandreu Neat. This could come in handy for |
I'd say this has lost steam. Close? |
We've basically been making Now that we have |
What are your thoughts on making
eslint-config-standard-strict
?This would be extra rules on top of
eslint-config-standard
that would add more checks, like:return /=foo/
)() => this
)At first, it can be not integrated into standard at all, but eventually can be added as
standard --strict
andstandard.lintFiles({ strict: true })
. This will also set the precedent that we can have--no-react
or similar flags.The text was updated successfully, but these errors were encountered: