Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runner::printProgress(): fix alignment of file counts #3106

Closed

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Sep 5, 2020

... when the total number of files is exactly dividable by 60.

Fixes #3058

For a "before" screenshot see the original issue.

"After" screenshot tested with various file counts:

image

... when the total number of files is exactly dividable by 60.

Fixes 3058
@gsherwood
Copy link
Member

Sorry :(

I got a bit excited when I saw the original report because I remember finding and fixing it in 4.0 (but forgetting to backport). I picked it in before noticing this.

Looks like we had the same fix in the end.

Thanks for taking the time to look into this though.

@gsherwood gsherwood closed this Sep 7, 2020
@jrfnl jrfnl deleted the feature/3058-progress-count-alignment branch September 7, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress gets unaligned when 100% happens at the end of the available dots
2 participants