Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress gets unaligned when 100% happens at the end of the available dots #3058

Closed
Slamdunk opened this issue Aug 28, 2020 · 3 comments
Closed

Progress gets unaligned when 100% happens at the end of the available dots #3058

Slamdunk opened this issue Aug 28, 2020 · 3 comments
Labels
Type: bug
Projects
PHPCS v3 Development
Milestone
3.5.7

Comments

@Slamdunk
Copy link

Expected vs Actual output diff

 $ vendor/bin/phpcs
 ............................................................  60 / 120 (50%)
-............................................................  120 / 120 (100%)
+............................................................                                                             120 / 120 (100%)
@jrfnl
Copy link
Contributor

jrfnl commented Sep 5, 2020

Tested and confirmed.

image

@jrfnl jrfnl mentioned this issue Sep 5, 2020
Closed
@jrfnl
Copy link
Contributor

jrfnl commented Sep 5, 2020

PR #3106 should fix this.

gsherwood added a commit that referenced this issue Sep 7, 2020
@gsherwood
Fixed progress output when the run completes at a wrap boundary (ref #…
a9cf57e 
…3058)
gsherwood added a commit that referenced this issue Sep 7, 2020
@gsherwood
Changelog for #3058
674cb96
@gsherwood gsherwood added this to Idea Bank in PHPCS v3 Development via automation Sep 7, 2020
@gsherwood gsherwood added this to the 3.5.7 milestone Sep 7, 2020
@gsherwood
Copy link
Member

Thanks for reporting this. I had fixed it in the 4.0 branch but forgot to cherry-pick that back into master.

For reference, original 4.0 commit was: 9c901a4

PHPCS v3 Development automation moved this from Idea Bank to Ready for Release Sep 7, 2020
@dependabot dependabot bot mentioned this issue Mar 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: bug
Projects
PHPCS v3 Development
Ready for Release
Milestone
3.5.7
Development

Successfully merging a pull request may close this issue.

Runner::printProgress(): fix alignment of file counts jrfnl/PHP_CodeSniffer
3 participants
@Slamdunk @gsherwood @jrfnl