Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Okcurl multiplatform build #7416

Merged
merged 7 commits into from Aug 15, 2022
Merged

Okcurl multiplatform build #7416

merged 7 commits into from Aug 15, 2022

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Aug 7, 2022

Still working with nativeImage, but technically a multiplatform build.

Towards being able to run a native or JS multiplatform okcurl.


class MainTest {
@Test fun simple() {
// @Test
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't work out why the build is failing on this package of all things...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding kotlin("test") to commonTest works for me (see yschimke#18). Not really sure how it works. I guess it's a special maven artifact that pulls the various implementations for different platforms

@yschimke yschimke added the graal GraalVM related label Aug 7, 2022
@yschimke yschimke mentioned this pull request Aug 8, 2022
8 tasks
@yschimke
Copy link
Collaborator Author

Thanks @martinbonnin I'm getting closer. Also working around this

palantir/gradle-graal#129

and now onto

$ okcurl/build/graal/okcurl                
Exception in thread "main" java.lang.NoClassDefFoundError: kotlin.jvm.internal.Intrinsics
        at okhttp3.curl.MainCommandLineKt.main(MainCommandLine.kt)

@yschimke yschimke marked this pull request as ready for review August 15, 2022 14:06
@yschimke
Copy link
Collaborator Author

Working with some workarounds, going to land as okcurl isn't a library module, and helps test the multiplatform libraries.

@yschimke yschimke merged commit ed21bd7 into square:master Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graal GraalVM related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants