Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OkHttp 5 blockers #7366

Closed
7 of 8 tasks
yschimke opened this issue Jul 3, 2022 · 11 comments
Closed
7 of 8 tasks

OkHttp 5 blockers #7366

yschimke opened this issue Jul 3, 2022 · 11 comments
Labels
enhancement Feature not a bug
Milestone

Comments

@yschimke
Copy link
Collaborator

yschimke commented Jul 3, 2022

@yschimke yschimke added the enhancement Feature not a bug label Jul 3, 2022
@yschimke yschimke added this to the 5.0 milestone Jul 3, 2022
@yschimke yschimke mentioned this issue Jul 3, 2022
4 tasks
@yschimke
Copy link
Collaborator Author

yschimke commented Jul 3, 2022

@swankjesse is Loom support in or out? #6385

Even just confirming it's supported, if not a distinct TaskRunner.Backend?

@swankjesse
Copy link
Member

I think Loom is out only because I don't expect it'll need API changes.

@yschimke
Copy link
Collaborator Author

I do think we'll need a new module with JDK 19+ dependencies, and probably change the implementation, potentially changes, maybe minor API changes, to TaskRunner.

@yschimke yschimke pinned this issue Jul 16, 2022
@yschimke
Copy link
Collaborator Author

yschimke commented Aug 8, 2022

Going to mark #7393 as done based on confirmation of current set against Chrome.

@yschimke
Copy link
Collaborator Author

yschimke commented Aug 8, 2022

@swankjesse Adding back Loom as I think #7367 showed we need to remove wait()/notify() and use Conditions instead in okhttp and okio.

@yschimke
Copy link
Collaborator Author

yschimke commented Aug 8, 2022

Also for KMP, I'm looking at using okcurl as a cross platform CLI buildable with all of graal, native, js. #7416

@yschimke
Copy link
Collaborator Author

yschimke commented Jan 3, 2023

HttpUrl supported, but without IDN.

@yschimke
Copy link
Collaborator Author

yschimke commented Jan 3, 2023

Suspend JS support is likely just the current example shown for ktor https://github.com/square/okhttp/pull/7326/files#diff-772553bc9e67a5b9842ab416490ff3fd80a8e7bd878ac641a9c0d644bce96492

Response will be read as part of the suspending executeAsync method.

@justinadkins
Copy link

Is there any news on when we can expect OkHttp 5 to be released?

@gesellix
Copy link

#5874 (HTTP 1.1 Upgrades) would be great to be included. It might not be a release blocker, though.

@yschimke
Copy link
Collaborator Author

I suspect #7164 could be a 5.1 feature if not in 5.0

@yschimke yschimke unpinned this issue May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature not a bug
Projects
None yet
Development

No branches or pull requests

4 participants