Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow obfuscate PublicSuffixDatabase #6974

Merged
merged 1 commit into from Jan 3, 2022
Merged

Allow obfuscate PublicSuffixDatabase #6974

merged 1 commit into from Jan 3, 2022

Conversation

vvb2060
Copy link
Contributor

@vvb2060 vvb2060 commented Dec 28, 2021

@yschimke
Copy link
Collaborator

Can you provide more context about why you need this and how it would work?

@vvb2060
Copy link
Contributor Author

vvb2060 commented Dec 28, 2021

I want to obfuscate as many classes as possible. -adaptresourcefilenames can change the resource and class names synchronously, which solves the problem of having to -keepnames PublicSuffixDatabase.

@JakeWharton
Copy link
Member

Does R8 support this? It is the more important shrinker to ensure works correctly.

@yschimke
Copy link
Collaborator

This seems pretty safe, particularly if testing with 5.0-alpha builds. Seems like this already happens for services.

https://r8.googlesource.com/r8/+/3601488e943e6bcdfb101e20be8bfbf4087354a6/src/main/java/com/android/tools/r8/shaking/ProguardConfiguration.java#60

@vvb2060
Copy link
Contributor Author

vvb2060 commented Dec 31, 2021

My last issue Kotlin/kotlinx.coroutines#3111 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants