OkHttp extension ships with a ProGuard rule that breaks newer versions of OkHttp

[Stonos]

ExoPlayer Version

2.17.1

Devices that reproduce the issue

All

Devices that do not reproduce the issue

No response

Reproducible in the demo app?

Not tested

Reproduction steps

1. Add the following to your build.gradle file:

implementation 'com.squareup.okhttp3:okhttp:5.0.0-alpha.7'
implementation 'com.google.android.exoplayer:extension-okhttp:2.17.1'

2. Add the following code somewhere:

PublicSuffixDatabase.get().getEffectiveTldPlusOne("example.com")

3. Compile a release version of the app with minifyEnabled true

Expected result

getEffectiveTldPlusOne should return example.com.

Actual result

getEffectiveTldPlusOne crashes with the following exception:

java.lang.IllegalStateException: Unable to load PublicSuffixDatabase.gz resource from the classpath.
        at okhttp3.internal.publicsuffix.PublicSuffixDatabase.a(SourceFile:501)

This happens because of this consumer rule that ships with the OkHttp extension:

ExoPlayer/extensions/okhttp/proguard-rules.txt

Line 8 in c386644

-keepnames class okhttp3.internal.publicsuffix.PublicSuffixDatabase

It probably stopped working due to this change in OkHttp: square/okhttp#6974

Media

N/A

Bug Report

• You will email the zip file produced by adb bugreport to dev.exoplayer@gmail.com after filing this issue.

[marcbaechinger]

Thanks for reporting.

I can repro this behaviour with the steps from above. I can also confirm that removing the mentioned line from the proguard rules solves the problem. It seems to work with 4.9.0 as well when I remove this line.

I'm not sure why we had this line actually. We followed the advice on the okhttp README at that time when it has been added.

Will check with okhttp folks.

[marcbaechinger]

This page suggests we can just remove our proguard config at least for gradle: https://square.github.io/okhttp/features/r8_proguard/

[Stonos]

Thanks for taking a look!

I think that it should be safe to delete the proguard-rules.txt file from the extension, since nowadays OkHttp is bundled with its own rules which should get picked up by R8.

I'm not sure why we had this line actually. We followed the advice on the okhttp README at that time when it has been added.

I believe that this is because at the time OkHttp didn't have embedded rules. The extension's rules were added on 2018-04-03, and OkHttp's rules were added on 2018-06-15.

[yschimke]

Yep - please remove any lines related to OkHttp from your file.

Basically since 3.11.0 our advice has been to rely on the embedded rules. So we stripped out all the other rules, and have taken advantage of that when moving files around.

[nuclearmagneton]

Any update on this?

[marcbaechinger]

Sorry, I haven't reference the commit in this issue. This landed on dev-v2 with this change:
759de7d

I'm closing this issue. Please let me know if you think there is something missing. Thanks.