Support for SIMILAR TO syntax, change Like and ILike to Expr variants, allow escape char for like/ilike
#569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… escape char to like/ilike
Pull Request Test Coverage Report for Build 2842050083
💛 - Coveralls |
This was referenced Aug 10, 2022
alamb
changed the title
SIMILAR TO syntax, change Like and ILike to Expr variants, allow escape char for like/ilike
alamb
reviewed
Aug 11, 2022
| @@ -438,6 +461,72 @@ impl fmt::Display for Expr { | |||
| high | |||
| ), | |||
| Expr::BinaryOp { left, op, right } => write!(f, "{} {} {}", left, op, right), | |||
| Expr::Like { | |||
There was a problem hiding this comment.
Seems to match https://www.postgresql.org/docs/current/functions-matching.html so 👍
| @@ -76,10 +78,6 @@ pub enum BinaryOperator { | |||
| And, | |||
| Or, | |||
| Xor, | |||
| Like, | |||
| BinaryOperator::Like | ||
| }, | ||
| right: Box::new(Expr::Value(Value::SingleQuotedString("%a".to_string()))), | ||
| Expr::Like { |
There was a problem hiding this comment.
Could you please also extend the parse_like and parse_ilike tests to include coverage of escape_char for both LIKE and ILIKE?
tests/sqlparser_common.rs
Outdated
| select.selection.unwrap() | ||
| ); | ||
|
|
||
| // This statement tests that LIKE and NOT LIKE have the same precedence. |
There was a problem hiding this comment.
This comment appears to be out of date
|
Marking this as a draft to show it is waiting some changes so I can easily filter out which PRs need review. Please mark it as "ready for review" when it is next ready. |
|
I believe a new version of rust has been released so we need to update lint on master (unrelated to this change) |
MazterQyou
pushed a commit
to cube-js/sqlparser-rs
that referenced
this pull request
Dec 1, 2022
…variants, allow escape char for like/ilike (sqlparser-rs#569) * Remove [not]like,[not]ilike from binary operator list * Add like, ilike and similar as an expr variant. Also adds support for escape char to like/ilike * Add parsing logic for similar to, update parsing logic for like/ilike * Add tests for similar to, update tests for like/ilike * Fix linter warnings * remove additional copyright license from files * Add more coverage w/wo escape char for like,ilike,similar to
MazterQyou
pushed a commit
to cube-js/sqlparser-rs
that referenced
this pull request
Dec 1, 2022
…variants, allow escape char for like/ilike (sqlparser-rs#569) * Remove [not]like,[not]ilike from binary operator list * Add like, ilike and similar as an expr variant. Also adds support for escape char to like/ilike * Add parsing logic for similar to, update parsing logic for like/ilike * Add tests for similar to, update tests for like/ilike * Fix linter warnings * remove additional copyright license from files * Add more coverage w/wo escape char for like,ilike,similar to
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds support for the
similar tosql operator syntax and also adds support to provide escape char to the[Not] like/ilikeoperators.