New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for SIMILAR TO
syntax, change Like
and ILike
to Expr
variants, allow escape char for like/ilike
#569
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3f21435
Remove [not]like,[not]ilike from binary operator list
ayushdg 0e28dd1
Add like, ilike and similar as an expr variant. Also adds support for…
ayushdg ab12adf
Add parsing logic for similar to, update parsing logic for like/ilike
ayushdg de06632
Add tests for similar to, update tests for like/ilike
ayushdg dc8615e
Fix linter warnings
ayushdg 70cc517
remove additional copyright license from files
ayushdg 1babc7b
Add more coverage w/wo escape char for like,ilike,similar to
ayushdg File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -76,10 +76,6 @@ pub enum BinaryOperator { | |
And, | ||
Or, | ||
Xor, | ||
Like, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
NotLike, | ||
ILike, | ||
NotILike, | ||
BitwiseOr, | ||
BitwiseAnd, | ||
BitwiseXor, | ||
|
@@ -116,10 +112,6 @@ impl fmt::Display for BinaryOperator { | |
BinaryOperator::And => f.write_str("AND"), | ||
BinaryOperator::Or => f.write_str("OR"), | ||
BinaryOperator::Xor => f.write_str("XOR"), | ||
BinaryOperator::Like => f.write_str("LIKE"), | ||
BinaryOperator::NotLike => f.write_str("NOT LIKE"), | ||
BinaryOperator::ILike => f.write_str("ILIKE"), | ||
BinaryOperator::NotILike => f.write_str("NOT ILIKE"), | ||
BinaryOperator::BitwiseOr => f.write_str("|"), | ||
BinaryOperator::BitwiseAnd => f.write_str("&"), | ||
BinaryOperator::BitwiseXor => f.write_str("^"), | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to match https://www.postgresql.org/docs/current/functions-matching.html so 👍