feat(parser): Make LIKE/ILIKE as a kind of Expr in ast, and parse ESCAPE
#15867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
TennyZhuang
force-pushed
the
feat/parse-like-escape
branch
from
b43d8af
to
b05cb06
Compare
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
TennyZhuang
requested review from
BugenZhao
and removed request for
chenzl25,
wangrunji0408 and
yuhao-su
wangrunji0408
approved these changes
Apr 1, 2024
Comment on lines
-185
to
+186
| SELECT 'abcdefg' SIMILAR TO '_bcd%' ESCAPE NULL AS null; | ||
| SELECT 'abcdefg' SIMILAR TO '_bcd#%' ESCAPE '##' AS error; | ||
| --@ SELECT 'abcdefg' SIMILAR TO '_bcd%' ESCAPE NULL AS null; | ||
| --@ SELECT 'abcdefg' SIMILAR TO '_bcd#%' ESCAPE '##' AS error; |
There was a problem hiding this comment.
Why are these tests disabled?
There was a problem hiding this comment.
Forget to support NULL as escape char, the output is always NULL. I guess it's not important, I'll fix it later.
There was a problem hiding this comment.
The behavior is confusing. Escape ‘’ means no escape, and escape NULL results NULL output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Prerequisite for #15701
Most of the codes are ported from the upstream.
Port sqlparser-rs/sqlparser-rs#569
Port sqlparser-rs/sqlparser-rs#1096
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.