Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce SqlServerSequenceMaxValueIncrementer for SQL Server sequences #29447

Conversation

fmbenhassine
Copy link
Contributor

@fmbenhassine fmbenhassine commented Nov 8, 2022

This PR introduces a DataFieldMaxValueIncrementer for SQL Server sequences.

Currently, Spring Batch and Spring Cloud Task are using duplicate copies of this incrementer.

It would be great if it is provided by Spring Framework to be used by other projects and avoid code duplication and maintenance.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 8, 2022
@sbrannen sbrannen self-assigned this Nov 8, 2022
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 8, 2022
@sbrannen sbrannen added this to the 6.0.0-RC4 milestone Nov 8, 2022
@sbrannen sbrannen changed the title Add DataFieldMaxValueIncrementer for SQL Server sequences Introduce DataFieldMaxValueIncrementer for SQL Server sequences Nov 8, 2022
@sbrannen sbrannen closed this in f9ed072 Nov 8, 2022
@sbrannen
Copy link
Member

sbrannen commented Nov 8, 2022

This has been merged into main just in time for 6.0 RC4.

Thanks!

@fmbenhassine fmbenhassine deleted the sqlserver-sequence-incrementer branch November 8, 2022 18:49
@sbrannen sbrannen changed the title Introduce DataFieldMaxValueIncrementer for SQL Server sequences Introduce SqlServerSequenceMaxValueIncrementer for SQL Server sequences Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants