Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPR-16886 Provide two mechanisms for SQL Server sequence incrementers. #2065

Closed
wants to merge 1 commit into from

Conversation

tkvangorder
Copy link

@tkvangorder tkvangorder commented Dec 31, 2018

This PR is to address a deadlocking issue with MS SQL Server and is related to https://jira.spring.io/browse/SPR-16886. Please see that issue for details.

I tried to ensure that this fix does not break downstream projects that leverage the incrementer on SQL Server.

This means that all versions of SQL Server are still going to use a sequence table with the difference being that the incrementer uses a reaper interval to delete records out of the sequence table.

I have also included an incrementer that can leverage native database sequences in 2012 and higher. It will be at the discretion of each downstream project as to when/if they want to leverage the new incrementer.

I am open to any feedback or changes you might want to make. I had toyed with requiring a platform transaction manager being injected into the incrementer (and creating a new transaction when the reaping interval was reached) as an alternative to using a thread, but I felt that was a more invasive change to downstream projects.

I have also updated my little test harness to use "copies" of the incrementers I have submitted in this pull request: https://github.com/tkvangorder/jdbc-sqlserver-incrementer

@snicoll snicoll added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 17, 2019
@rstoyanchev rstoyanchev added the in: data Issues in data modules (jdbc, orm, oxm, tx) label Nov 10, 2021
@sbrannen sbrannen self-assigned this Feb 21, 2023
@sbrannen sbrannen added type: enhancement A general enhancement status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Feb 21, 2023
@sbrannen
Copy link
Member

sbrannen commented Feb 21, 2023

Closing as superseded by the following issues which have been closed.

If you feel that something is missing which still needs to be addressed, please open a new issue.

@sbrannen sbrannen closed this Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) status: superseded An issue that has been superseded by another type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants