Introduce createContext() factory method in AbstractGenericContextLoader #25600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maciejmiklas Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@maciejmiklas Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
changed the title
sbrannen
added
in: test
Why does |
sbrannen
added
the
status: waiting-for-feedback
|
because I would like to replace (use my custom implementation) of DefaultListableBeanFactory.
The whole point of this change is to be able to replace DefaultListableBeanFactory. It's possible with AnnotationConfigWebApplicationContext but not for Unit-Tests
… On 17 Aug 2020, at 14:23, Sam Brannen ***@***.***> wrote:
Now we would like to customize the Bean Factory for Unit Tests.
Why does org.springframework.test.context.support.AbstractGenericContextLoader.customizeBeanFactory(DefaultListableBeanFactory) not meet your needs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#25600 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZMFRFHCXAKCK5XZGYIO6DSBEOMRANCNFSM4QBSR57A>.
|
spring-projects-issues
added
status: feedback-provided
sbrannen
removed
status: waiting-for-triage
Understood. Thanks for the prompt feedback. I think it should be relatively safe to include such a change in |
|
Thank you! |
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this pull request
Aug 17, 2020
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this pull request
Aug 21, 2022
…Loader Prior to this commit it was possible to configure the DefaultListableBeanFactory used by the GenericWebApplicationContext created by AbstractWebGenericContextLoader, but it was not possible to completely replace the bean factory. This commit introduces a new createContext() factory method in AbstractWebGenericContextLoader which indirectly allows subclasses to supply a custom DefaultListableBeanFactory implementation to the GenericWebApplicationContext. See spring-projectsgh-25600 Closes spring-projectsgh-28983
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this pull request
Aug 21, 2022
…Loader Prior to this commit it was possible to configure the DefaultListableBeanFactory used by the GenericWebApplicationContext created by AbstractWebGenericContextLoader, but it was not possible to completely replace the bean factory. This commit introduces a new createContext() factory method in AbstractWebGenericContextLoader which indirectly allows subclasses to supply a custom DefaultListableBeanFactory implementation to the GenericWebApplicationContext. See spring-projectsgh-25600 Closes spring-projectsgh-28983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have customized
DefaultListableBeanFactoryand are using it already inAnnotationConfigWebApplicationContextfor production.Now we would like to customize the
DefaultListableBeanFactoryfor integration tests as well, but in order to archive that we need a new factory method inAbstractGenericContextLoader.