Skip to content

Commit

Permalink
Introduce createContext() factory method in AbstractWebGenericContext…
Browse files Browse the repository at this point in the history
…Loader

Prior to this commit it was possible to configure the
DefaultListableBeanFactory used by the GenericWebApplicationContext
created by AbstractWebGenericContextLoader, but it was not possible to
completely replace the bean factory.

This commit introduces a new createContext() factory method in
AbstractWebGenericContextLoader which indirectly allows subclasses to
supply a custom DefaultListableBeanFactory implementation to the
GenericWebApplicationContext.

See spring-projectsgh-25600
Closes spring-projectsgh-28983
  • Loading branch information
sbrannen committed Aug 21, 2022
1 parent 69d87f1 commit 711820e
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 5 deletions.
Expand Up @@ -200,9 +200,10 @@ public final ConfigurableApplicationContext loadContext(String... locations) thr
* Factory method for creating the {@link GenericApplicationContext} used by
* this {@code ContextLoader}.
* <p>The default implementation creates a {@code GenericApplicationContext}
* using the default constructor. This method may get overridden e.g. to use
* a custom context subclass or to create a {@code GenericApplicationContext}
* with a custom {@link DefaultListableBeanFactory} implementation.
* using the default constructor. This method may be overridden &mdash; for
* example, to use a custom context subclass or to create a
* {@code GenericApplicationContext} with a custom
* {@link DefaultListableBeanFactory} implementation.
* @return a newly instantiated {@code GenericApplicationContext}
* @since 5.2.9
*/
Expand Down
@@ -1,5 +1,5 @@
/*
* Copyright 2002-2021 the original author or authors.
* Copyright 2002-2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -114,7 +114,7 @@ public final ConfigurableApplicationContext loadContext(MergedContextConfigurati

validateMergedContextConfiguration(webMergedConfig);

GenericWebApplicationContext context = new GenericWebApplicationContext();
GenericWebApplicationContext context = createContext();

ApplicationContext parent = mergedConfig.getParentApplicationContext();
if (parent != null) {
Expand Down Expand Up @@ -145,6 +145,21 @@ protected void validateMergedContextConfiguration(WebMergedContextConfiguration
// no-op
}

/**
* Factory method for creating the {@link GenericWebApplicationContext} used
* by this {@code ContextLoader}.
* <p>The default implementation creates a {@code GenericWebApplicationContext}
* using the default constructor. This method may be overridden &mdash; for
* example, to use a custom context subclass or to create a
* {@code GenericWebApplicationContext} with a custom
* {@link DefaultListableBeanFactory} implementation.
* @return a newly instantiated {@code GenericWebApplicationContext}
* @since 5.2.23
*/
protected GenericWebApplicationContext createContext() {
return new GenericWebApplicationContext();
}

/**
* Configures web resources for the supplied web application context (WAC).
* <h4>Implementation Details</h4>
Expand Down

0 comments on commit 711820e

Please sign in to comment.