Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileUrlResource isWritable method returns true if URL protocol is not indicating a file #25584

Closed
wants to merge 2 commits into from
Closed

FileUrlResource isWritable method returns true if URL protocol is not indicating a file #25584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d205ab7
fix FileUrlResource isWritable method when not file return true bug
yilianhuaixiao Aug 14, 2020
312596d
Polishing
yilianhuaixiao Aug 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion spring-core/src/main/java/org/springframework/core/io/FileUrlResource.java
View file
Open in desktop
Expand Up @@ -59,6 +59,7 @@ public class FileUrlResource extends UrlResource implements WritableResource {
*/
public FileUrlResource(URL url) {
super(url);
Assert.isTrue(ResourceUtils.isFileURL(url),"url's protocol must be file or start with vfs");
}

/**
Expand Down Expand Up @@ -96,7 +97,7 @@ public boolean isWritable() {
return (file.canWrite() && !file.isDirectory());
}
else {
return true;
return false;
}
}
catch (IOException ex) {
Expand Down
7 changes: 7 additions & 0 deletions spring-core/src/test/java/org/springframework/core/io/ResourceTests.java
View file
Open in desktop
Expand Up @@ -330,4 +330,11 @@ void readableChannelNotFoundOnClassPathResource() throws IOException {
new ClassPathResource("Resource.class", getClass()).createRelative("X").readableChannel());
}

@Test
void fileUrlResourceTest() throws IOException {
assertThatIllegalArgumentException().isThrownBy(() -> {
new FileUrlResource(new URL("https://spring.io/"));
});
}

}