FileUrlResource isWritable method returns true if URL protocol is not indicating a file #25584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jhoeller
added
in: core
jhoeller
changed the title
|
I've addressed this somewhat differently, exclusively relying on Thanks for spotting this - and thanks for the pull request, in any case! |
jhoeller
added
the
for: backport-to-5.1.x
spring-projects-issues
added
status: backported
engimatic
pushed a commit
to engimatic/spring-framework
that referenced
this pull request
Sep 29, 2020
…tation Closes spring-projectsgh-25584 (cherry picked from commit c6cc670)
zx20110729
pushed a commit
to zx20110729/spring-framework
that referenced
this pull request
Feb 18, 2022
…tation Closes spring-projectsgh-25584 (cherry picked from commit c6cc670)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if add testcase
@Test void test() throws IOException { Resource resource = new FileUrlResource(new URL("https://spring.io/")); assertThat(resource.isReadable()).isFalse(); }the former code cannot pass.
Then I restricted FileUrlResource must be contructed with a URL about file.