Introduce tests for MultiValueMap #25160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
requested changes
May 29, 2020
spring-core/src/test/java/org/springframework/util/MultiValueMapRelatedTests.java
Outdated
Show resolved
Hide resolved
spring-core/src/test/java/org/springframework/util/MultiValueMapRelatedTests.java
Outdated
Show resolved
Hide resolved
spring-core/src/test/java/org/springframework/util/MultiValueMapRelatedTests.java
Outdated
Show resolved
Hide resolved
sbrannen
added
in: core
sbrannen
changed the title
|
@sbrannen thank you very much for your review. I will also change the name of the test to: MultiValueMapAdaptersTests to reflect current changes done by Juergen. |
Closed
spring-projects-issues
added
status: feedback-provided
midumitrescu
force-pushed
the
improved-unit-test
branch
from
456cd83
to
f8376e4
Compare
sbrannen
approved these changes
May 29, 2020
midumitrescu
force-pushed
the
improved-unit-test
branch
from
f8376e4
to
18b6d96
Compare
|
@sbrannen done I did not trust myself to delete But imho they are now fully migrated with the parameterized tests |
snicoll
pushed a commit
that referenced
this pull request
Aug 25, 2023
snicoll
added a commit
that referenced
this pull request
Aug 25, 2023
|
Thanks @midumitrescu, I've enabled the tests that were disabled as the fix has been added in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imho improved tests for gh-25140, as solicited by @jhoeller
As promised in gh-25159, I am submitting a second suggestion for Testing the exiting code of
The suggestion was to create for this MultiValueMap same tests as for
present in
This, however, produced a very high code duplication, which I did not find very elegant.
I think the better way is to use Jupiter properly, to instantiate various types of MultiValueMap and test the contract for each of them.
Like this test code is not duplicated and the contracts are consistent with each other.
This is just a suggestion.
I am open for suggestions in case this does not fit your expectations.
Kind regards