Tests for gh-25140 #25159
Closed
Tests for gh-25140 #25159
+208
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
midumitrescu
force-pushed
the
unit-tests-multi-valued-map-adaptor
branch
from
5d60117
to
f8c5787
Compare
|
in favor of gh-25160 |
sbrannen
added
status: superseded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created unit tests for
as suggested by @jhoeller in gh-25140
I just followed the instructions given there although I could imagine a better solution which is a lot more DRY.
I will create a second PR for comparison.
I would have 2 small questions:
but the test I have named CollectionUtilsMultiValueMapAdapterTests.
Is this OK with you or are you following a strong name convention, thus I should move the tests to CollectionUtilsTest ?