Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support JdkClientHttpConnector in DefaultWebTestClientBuilder #29644

Closed
mhalbritter opened this issue Dec 6, 2022 · 3 comments
Closed

Support JdkClientHttpConnector in DefaultWebTestClientBuilder #29644

mhalbritter opened this issue Dec 6, 2022 · 3 comments
Labels
in: test Issues in the test module status: superseded An issue that has been superseded by another type: enhancement A general enhancement

Comments

@mhalbritter
Copy link
Contributor

mhalbritter commented Dec 6, 2022 •
edited

In org.springframework.test.web.reactive.server.DefaultWebTestClientBuilder#initConnector there are checks for Reactor Netty, Jetty and Apache Http for the ClientHttpConnector implementation. As there is now a JdkClientHttpConnector which works without external dependencies, I think it would be nice if DefaultWebTestClientBuilder could fallback to that instead of throwing an exception.

I don't know if there are more places which do this auto-detection of ClientHttpConnector, but if there are, it would be nice to update them to include JdkClientHttpConnector.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 6, 2022
@mhalbritter
Copy link
Contributor Author

org.springframework.web.reactive.function.client.DefaultWebClientBuilder#initConnector has the same detection, and there JdkClientHttpConnector is already integrated. I will create a PR which updates DefaultWebTestClientBuilder.

@mhalbritter mhalbritter mentioned this issue Dec 6, 2022
Merged
@mhalbritter
Copy link
Contributor Author

See #29645

@jhoeller jhoeller added in: test Issues in the test module type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 6, 2022
@jhoeller jhoeller modified the milestone: 6.0.3 Dec 6, 2022
@jhoeller jhoeller added the status: superseded An issue that has been superseded by another label Dec 6, 2022
@jhoeller
Copy link
Contributor

jhoeller commented Dec 6, 2022

Superseded by #29645.

@jhoeller jhoeller closed this as completed Dec 6, 2022
@mhalbritter mhalbritter mentioned this issue Dec 6, 2022
Closed
@anugrahsinghal anugrahsinghal mentioned this issue Dec 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: test Issues in the test module status: superseded An issue that has been superseded by another type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jhoeller @spring-projects-issues @mhalbritter