Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Jetty / Netty / Apache HttpClient checks for WebClient #33474

Closed
mhalbritter opened this issue Dec 6, 2022 · 2 comments
Closed

Remove Jetty / Netty / Apache HttpClient checks for WebClient #33474

mhalbritter opened this issue Dec 6, 2022 · 2 comments
Labels
status: superseded An issue that has been superseded by another

Comments

@mhalbritter
Copy link
Contributor

With spring-projects/spring-framework#29644 the WebClient doesn't need external dependencies anymore. If no netty / jetty / Apache HttpClient is found, it falls back to the JdkClientHttpConnector which is baked into the JDK.

At least in org.springframework.boot.test.web.reactive.server.WebTestClientContextCustomizerFactory we check for the presence of netty / jetty / apache httpclient. This check can be removed, and maybe such checks are somewhere else in the codebase.

@wilkinsona
Copy link
Member

I wonder if we should consider this a bug? Looking at the code, the checks are preventing the auto-configuration of a WebTestClient that uses the JdkClientHttpConnector.

@wilkinsona wilkinsona added the for: team-attention An issue we'd like other members of the team to review label Jan 3, 2023
@scottfrederick
Copy link
Contributor

Closing in favor of #33640.

@scottfrederick scottfrederick closed this as not planned Won't fix, can't repro, duplicate, stale Jan 3, 2023
@scottfrederick scottfrederick removed type: enhancement A general enhancement for: team-attention An issue we'd like other members of the team to review labels Jan 3, 2023
@scottfrederick scottfrederick removed this from the 3.1.x milestone Jan 3, 2023
@scottfrederick scottfrederick added the status: superseded An issue that has been superseded by another label Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Development

No branches or pull requests

3 participants