Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Jetty/Netty/ApacheHttpClient checks for WebClient #33640

Closed
wants to merge 2 commits into from

Conversation

anugrahsinghal
Copy link
Contributor

adds the functionality according to #33474

  • removes additional checks for netty/jetty/Apache HttpClient dependencies

@pivotal-cla
Copy link

@anugrahsinghal Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@anugrahsinghal Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 27, 2022
@anugrahsinghal
Copy link
Contributor Author

anugrahsinghal commented Dec 27, 2022

At least in org.springframework.boot.test.web.reactive.server.WebTestClientContextCustomizerFactory we check for the presence of netty / jetty / apache httpclient. This check can be removed, and maybe such checks are somewhere else in the codebase.

@mhalbritter
I have used this sourcegraph query to find the presence of similar dependencies in other places in the codebase, and could not find one that would need removal.


this sourcegraph query
essentially checks for the presence of

"reactor.netty.http.client.HttpClient"
"org.eclipse.jetty.client.HttpClient"
"org.apache.hc.client5.http.impl.async.CloseableHttpAsyncClient"
"org.apache.hc.core5.reactive.ReactiveDataConsumer"

in spring-projects org

@anugrahsinghal
Copy link
Contributor Author

anugrahsinghal commented Dec 27, 2022

@mhalbritter a little bit unsure of how to handle this test

since we removed the conditions that checked for the presence of netty/jetty/apache client
the WebTestClientContextCustomizerFactory is always non-null
even after the @ClassPathExclusions({ "reactor-netty*.jar", "jetty-client*.jar" })

Do you have any suggestions on how to modify this test case?

@anugrahsinghal anugrahsinghal marked this pull request as ready for review December 27, 2022 13:33
@scottfrederick scottfrederick added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 3, 2023
@scottfrederick scottfrederick added this to the 3.0.x milestone Jan 3, 2023
@scottfrederick
Copy link
Contributor

@anugrahsinghal I think the WebTestClientContextCustomizerWithoutSupportedHttpClientTests can be removed, since there is no longer a case where no client is availble.

@anugrahsinghal
Copy link
Contributor Author

hey @scottfrederick

I have removed the WebTestClientContextCustomizerWithoutSupportedHttpClientTests test.

@mhalbritter
Copy link
Contributor

Thanks and congratulations to your first contribution to Spring Boot!

@mhalbritter mhalbritter modified the milestones: 3.0.x, 3.0.2 Jan 9, 2023
mhalbritter added a commit to spring-projects/spring-aot-smoke-tests that referenced this pull request Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants