Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce TestSocketUtils as a replacement for SocketUtils #28210

Closed
sbrannen opened this issue Mar 21, 2022 · 4 comments
Closed

Introduce TestSocketUtils as a replacement for SocketUtils #28210

sbrannen opened this issue Mar 21, 2022 · 4 comments
Labels
in: test Issues in the test module status: superseded An issue that has been superseded by another type: enhancement A general enhancement

Comments

@sbrannen
Copy link
Member

sbrannen commented Mar 21, 2022 •
edited

SocketUtils was officially deprecated in 5.3.16 (#28052) and removed in 6.0 M3 (#28054); however, there is still need for a subset of this functionality in integration tests for testing scenarios in which it is not possible for the system under test to select its own random port (or rely on the operating system to provide an ephemeral port).

We will therefore introduce a scaled down version in spring-test called TestSocketUtils, supporting retrieval of a single TCP port, and potentially with a simple retry mechanism that allows test code using the available port to be retried a given number of times if an exception is thrown.
@sbrannen sbrannen added in: test Issues in the test module type: enhancement A general enhancement labels Mar 21, 2022
@sbrannen sbrannen added this to the 5.3.18 milestone Mar 21, 2022
@sbrannen sbrannen self-assigned this Mar 21, 2022
This was referenced Mar 21, 2022
Closed
Closed
Closed
@onobc onobc mentioned this issue Mar 23, 2022
Closed
2 tasks
@snicoll snicoll modified the milestones: 5.3.18, 5.3.19 Mar 31, 2022
@sbrannen sbrannen modified the milestones: 5.3.19, 5.3.x Apr 9, 2022
@asibross
Copy link

Was this added to any 5.3.x version?

@sbrannen
Copy link
Member Author

Was this added to any 5.3.x version?

No, this issue is still open and assigned to the 5.3.x backlog.

onobc added a commit to onobc/spring-framework that referenced this issue Sep 11, 2022
@onobc
Add TestSocketUtils to spring-test
f2c2374 
Fixes spring-projects#28210
@onobc onobc mentioned this issue Sep 11, 2022
Closed
@artemptushkin
Copy link

Spring boot 3 is coming and this would be really needed, any chance we can raise the priority?

@sbrannen sbrannen modified the milestones: 5.3.x, 5.3.24 Nov 1, 2022
@sbrannen sbrannen removed this from the 5.3.24 milestone Nov 14, 2022
@sbrannen sbrannen added the status: superseded An issue that has been superseded by another label Nov 14, 2022
@sbrannen
Copy link
Member Author

@sbrannen sbrannen closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2022
@sbrannen sbrannen removed their assignment Nov 14, 2022
@azizbekxm azizbekxm mentioned this issue Jan 20, 2023
Merged
14 tasks
@fennec-fox fennec-fox mentioned this issue Mar 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: test Issues in the test module status: superseded An issue that has been superseded by another type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce TestSocketUtils as a replacement for SocketUtils onobc/spring-framework
4 participants
@sbrannen @snicoll @asibross @artemptushkin