Introduce TestSocketUtils as a replacement for SocketUtils #29132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
onobc
commented
Sep 11, 2022
spring-test/src/test/java/org/springframework/test/util/TestSocketUtilsTests.java
Show resolved
Hide resolved
r331
reviewed
Sep 13, 2022
spring-test/src/main/java/org/springframework/test/util/TestSocketUtils.java
Show resolved
Hide resolved
sbrannen
added
in: test
sbrannen
changed the title
sbrannen
removed
the
status: waiting-for-triage
sbrannen
approved these changes
Nov 14, 2022
sbrannen
pushed a commit
to sbrannen/spring-framework
that referenced
this pull request
Nov 14, 2022
SocketUtils was officially deprecated in 5.3.16 (spring-projectsgh-28052) and removed in 6.0 M3 (spring-projectsgh-28054); however, there is still need for a subset of this functionality in integration tests for testing scenarios in which it is not possible for the system under test to select its own random port (or rely on the operating system to provide an ephemeral port). This commit therefore introduces a scaled down version in the spring-test module called TestSocketUtils which supports retrieval of a single TCP port. See spring-projectsgh-29132
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
TestSocketUtilsas a replacement for the deprecatedSocketUtils. It was borrowed from https://github.com/spring-projects/spring-framework/blob/main/spring-core/src/testFixtures/java/org/springframework/core/testfixture/net/TestSocketUtils.java.Fixes #28210