Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace local TestSocketUtils with the one in spring-test #834

Closed
2 tasks
onobc opened this issue Mar 23, 2022 · 3 comments
Closed
2 tasks

Replace local TestSocketUtils with the one in spring-test #834

onobc opened this issue Mar 23, 2022 · 3 comments
Assignees
Labels
Milestone

Comments

@onobc
Copy link
Contributor

onobc commented Mar 23, 2022

Once spring-projects/spring-framework#28210 adds TestSocketUtils we should remove the temporary ones recently added:

@onobc onobc self-assigned this Mar 23, 2022
@olegz
Copy link
Contributor

olegz commented Mar 23, 2022

As discussed, we can also remove SocketUtils that I just created inside of SCF

@olegz olegz added the task label Mar 23, 2022
@olegz olegz added this to the 4.0 milestone Mar 23, 2022
@olegz
Copy link
Contributor

olegz commented Apr 21, 2022

Chris, should we close it? If I remember correctly we discussed that it will be addressed with your Azure custom runtime commit

@onobc
Copy link
Contributor Author

onobc commented Apr 21, 2022

No this is still waiting on the change in the framework. Once its available I will get it in here.

I think you are thinking that I would remove the public one that was added in previous commits (in the scope of my PR - which I have not gotten to yet but will shortly).

@olegz olegz removed this from the 4.0 milestone Dec 15, 2022
@olegz olegz added this to the 4.1 milestone Oct 23, 2023
@olegz olegz closed this as completed in f1e330a Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants