Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent Environment access in XML bean definition parsing code [SPR-12248] #16862

Closed
spring-projects-issues opened this issue Sep 24, 2014 · 0 comments
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Sep 24, 2014

Juergen Hoeller opened SPR-12248 and commented

Dating back to the Spring 3.1 days, there is quite a bit of explicit passing around of Environment references in Spring's XML bean definition parsing code, e.g. in BeanDefinitionParserDelegate and DefaultBeanDefinitionDocumentReader. With the introduction of a convenient XmlReaderContext.getEnvironment() method, there is really no need for explicit Environment fields anymore.

This allows for deprecating BeanDefinitionDocumentReader.setEnvironment and BeanDefinitionParserDelegate(XmlReaderContext, Environment), as well as as undeprecating BeanDefinitionParserDelegate(XmlReaderContext). Some preparation measures are also going to be backported to 4.0.8 and 3.2.12, including a fully working version of the latter constructor.


Affects: 4.1 GA

Issue Links:

Referenced from: commits de3ea5d, 5ecdd8c, d46c3fc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants