Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please let context:component-scan base-package eval placeholder then split by comma [SPR-10425] #15058

Closed
spring-projects-issues opened this issue Mar 28, 2013 · 6 comments
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Mar 28, 2013

Yanming Zhou opened SPR-10425 and commented

<context:component-scan base-package="${APP_BASE_PACKAGE}"/>
<!--APP_BASE_PACKAGE=com.test1,com.test2 -->

it doesn't works

must be

<context:component-scan base-package="${APP_BASE_PACKAGE1},${APP_BASE_PACKAGE2}"/>
<!--
APP_BASE_PACKAGE1=com.test1
APP_BASE_PACKAGE2=com.test2 
-->

it's not friendly for variable packages

https://jira.springsource.org/browse/SPR-4351
https://jira.springsource.org/browse/SPR-10424


Reference URL: https://jira.springframework.org/browse/SPR-4351

Issue Links:

1 votes, 2 watchers

@spring-projects-issues
Copy link
Collaborator Author

Yanming Zhou commented

ping

@spring-projects-issues
Copy link
Collaborator Author

Yanming Zhou commented

I have created a PR on Github
#650

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Finally addressed for 4.1.1! Please give the upcoming 4.1.1 snapshot a try and let me know whether it works for you...

Juergen

@spring-projects-issues
Copy link
Collaborator Author

Yanming Zhou commented

ComponentScanAnnotationParser should be same behavior as ComponentScanBeanDefinitionParser.

@spring-projects-issues
Copy link
Collaborator Author

Yanming Zhou commented

It works fine with version "4.1.1.BUILD-20140924.233856-34", thanks !

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Good point, applied to ComponentScanAnnotationParser as well - this will show up in the next 4.1.1 snapshot.

Juergen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants