Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make context:exclude-filter expression supports placeholder like context:component-scan base-package [SPR-10424] #15057

Closed
spring-projects-issues opened this issue Mar 28, 2013 · 5 comments
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Mar 28, 2013

Yanming Zhou opened SPR-10424 and commented

<context:component-scan base-package="${APP_BASE_PACKAGE}">
<context:exclude-filter type="regex" expression="${APP_EXCLUDE_PACKAGE:}"/>
</context:component-scan>

same to context:include-filter


Reference URL: https://jira.springsource.org/browse/SPR-4351

Issue Links:

@spring-projects-issues
Copy link
Collaborator Author

Yanming Zhou commented

ping

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Finally addressed for 4.1.1! Please give the upcoming 4.1.1 snapshot a try and let me know whether it works for you...

Juergen

@spring-projects-issues
Copy link
Collaborator Author

Yanming Zhou commented

It works fine with version "4.1.1.BUILD-20140924.233856-34", thanks !

@spring-projects-issues
Copy link
Collaborator Author

Yanming Zhou commented

Should exclude-filter and include-filter supports comma seperation? so we can use one placeholder to rule them all.

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

I'm afraid this is significantly harder since filter expressions can have many formats, with a comma - or any other character - not necessarily being a good separator. I'd rather leave this as-is, just supporting the auto-splitting for base package specifications (along the lines of many other places where we support comma-separated class and package names).

Juergen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants