Add warning about spring.config.additional-location #20743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is unclear from the documentation that the `spring.config.location` and `spring.config.additional-location` properties are mutually exclusive. This change explicitly documents it.
|
@andersthorbeck Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@andersthorbeck Thank you for signing the Contributor License Agreement! |
|
Thanks for the proposal. I'm not sure that it's intentional for those two properties to be mutually exclusive. I've opened #20745 so that we can take a step back and consider how we think things should behave and, if we decide that a change in behaviour is required, in what branch it should be changed. |
wilkinsona
added
status: superseded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unclear from the documentation that the
spring.config.locationandspring.config.additional-locationproperties are mutually exclusive. This change explicitly documents it.The wording is subject to change, but I think the fact that these properties are mutually exclusive should be documented explicitly.
It took me about a day (before eventually delving into the spring code in
ConfigFileApplicationListener) to realize I could not use these in tandem, I would like to avoid others having to make the same mistake.