Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring.config.additional-location is ignored when spring.config.location is configured #20745

Closed
wilkinsona opened this issue Mar 31, 2020 · 0 comments
Labels
type: bug A general bug
Milestone

Comments

@wilkinsona
Copy link
Member

This issue relates to #20743.

When we fixed #10595, I don't think we considered a scenario where both spring.config.additional-location and spring.config.location are configured. As things stand, when spring.config.location is configured, spring.config.additional-location is ignored. I'm not sure that this is the right behaviour.

The documentation for spring.config.location states that its locations "replace the default locations". The documentation for spring.config.addition-location states that its locations "are used in addition to the default locations". Given this description of the behaviour, I think it's reasonable to expect the additional locations to be used as well as those that have replaced the defaults.

@wilkinsona wilkinsona added type: bug A general bug for: team-attention An issue we'd like other members of the team to review labels Mar 31, 2020
@wilkinsona wilkinsona removed the for: team-attention An issue we'd like other members of the team to review label Apr 3, 2020
@wilkinsona wilkinsona added this to the 2.2.x milestone Apr 3, 2020
@mbhave mbhave closed this as completed in 4e0fdbe Apr 21, 2020
@mbhave mbhave modified the milestones: 2.2.x, 2.2.7 Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants