New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify the type to which connection-pool-specific spring.datasource
properties are bound
#20727
Clarify the type to which connection-pool-specific spring.datasource
properties are bound
#20727
Conversation
…Hikari Datasource properties Fixes spring-projectsgh-20688
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for the pull request. I've suggested a small refinement. Could you please take a look and, if you agree, update things accordingly?
.../java/org/springframework/boot/build/context/properties/DocumentConfigurationProperties.java
Outdated
Show resolved
Hide resolved
spring.datasource.hikari.*
properties are bound to a HikariDataSource
instance
spring.datasource.hikari.*
properties are bound to a HikariDataSource
instancespring.datasource
properties are bound
spring.datasource
properties are boundspring.datasource
properties are bound
Thanks very much for making your first contribution to Spring Boot, @parameswaranvv. In reviewing the changes, I realised that they were applicable to Commons DBCP2 and Tomcat JDBC as well. I made similar updates for both of those in a polishing commit. I also had to drop the use of backticks around the class name as the column in the table was rendering them as-is. Apologies for the bad suggestion there. |
For issue: #20688, Minor change to description of Hikari Datasource properties in documentation
Fixes gh-20688