Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that spring.datasource.hikari.* properties are bound to a HikariDataSource instance #20688

Closed
wilkinsona opened this issue Mar 26, 2020 · 1 comment
Closed

Clarify that spring.datasource.hikari.* properties are bound to a HikariDataSource instance #20688

wilkinsona opened this issue Mar 26, 2020 · 1 comment
Labels
status: superseded An issue that has been superseded by another type: documentation A documentation update

Comments

@wilkinsona
Copy link
Member

The documentation lists all of the third-party properties that can be bound, but simply described them as being "Hikari specific settings". We could help users to understand what the properties are bound to by replacing this with something like "Hikari-specific settings bound to an instance of HikariDataSource".
@wilkinsona wilkinsona added this to the 2.2.x milestone Mar 26, 2020
@wilkinsona wilkinsona added the type: documentation A documentation update label Mar 26, 2020
parameswaranvv added a commit to parameswaranvv/spring-boot that referenced this issue Mar 30, 2020
@parameswaranvv
Issue: spring-projects#20688 - Updated documentation description for …
d81e2c0 
…Hikari Datasource properties

Fixes spring-projectsgh-20688
@parameswaranvv parameswaranvv mentioned this issue Mar 30, 2020
Closed
parameswaranvv added a commit to parameswaranvv/spring-boot that referenced this issue Mar 30, 2020
@parameswaranvv
Changed description to use the class name for better clarity
808c07a 
Fixes spring-projectsgh-20688
parameswaranvv added a commit to parameswaranvv/spring-boot that referenced this issue Mar 30, 2020
@parameswaranvv
Changed description to use the class name for better clarity
f6a6ccf 
Fixes spring-projectsgh-20688
@wilkinsona
Copy link
Member Author

wilkinsona commented Mar 30, 2020 •
edited by philwebb

Closing in favor of #20727.

@wilkinsona wilkinsona removed this from the 2.2.x milestone Mar 30, 2020
@wilkinsona wilkinsona added the status: superseded An issue that has been superseded by another label Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another type: documentation A documentation update
Projects
None yet
Milestone
No milestone
1 participant
@wilkinsona