Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL's retryWrites query parameter is ignored when auto-configuring a reactive Mongo client #14032

Closed
wants to merge 1 commit into from
Closed

URL's retryWrites query parameter is ignored when auto-configuring a reactive Mongo client #14032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions ...rc/main/java/org/springframework/boot/autoconfigure/mongo/ReactiveMongoClientFactory.java
View file
Open in desktop
Expand Up @@ -159,6 +159,7 @@ private Builder createBuilder(MongoClientSettings settings,
if (connection.getApplicationName() != null) {
builder.applicationName(connection.getApplicationName());
}
builder.retryWrites(connection.getRetryWrites());
return builder;
}

Expand Down
8 changes: 8 additions & 0 deletions ...st/java/org/springframework/boot/autoconfigure/mongo/ReactiveMongoClientFactoryTests.java
View file
Open in desktop
Expand Up @@ -112,6 +112,14 @@ public void uriCanBeCustomized() {
assertMongoCredential(credential, "user", "secret", "test");
}

@Test
public void retryWritesIsPropagatedFromUri() {
MongoProperties properties = new MongoProperties();
properties.setUri("mongodb://localhost/test?retryWrites=true");
MongoClient client = createMongoClient(properties);
assertThat(client.getSettings().getRetryWrites()).isTrue();
}

@Test
public void uriCannotBeSetWithCredentials() {
MongoProperties properties = new MongoProperties();
Expand Down