URL's retryWrites query parameter is ignored when auto-configuring a reactive Mongo client #14032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue this PR attempts to fix affects Boot 2.0 and master branches. Should I target |
spring-projects-issues
added
the
status: waiting-for-triage
|
Yes, please. It looks like a bug to me so should be fixed in 2.0.x. |
Add retryWrites flag to set of flags propagated from connection string to ReactiveMongoClient. Regular MongoClientFactory relies of MongoClientURI class that propagates all flags in its getOptions() method.
GreyTeardrop
force-pushed
the
propagate-mongo-retrywrites
branch
from
7517124
to
140d544
Compare
|
I've rebased commit on top of 2.0.x. Not sure how to trigger CI again though. |
|
We don't have pull request builds for 2.0.x set up on CI. I've created an issue for that here. |
wilkinsona
changed the title
wilkinsona
added
type: bug
|
Thanks very much, @GreyTeardrop. The proposed changes are now in both 2.0.x and master. |
wilkinsona
pushed a commit
that referenced
this pull request
Aug 13, 2018
wilkinsona
added a commit
that referenced
this pull request
Aug 13, 2018
* gh-14032: Propagate retryWrites flag from connection URI to ReactiveMongoClient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
retryWritesflag to set of flags propagated fromconnectionStringto
ReactiveMongoClient.Regular
MongoClientFactoryrelies ofMongoClientURIclass thatpropagates all flags in its
getOptions()method.