Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NullPointerException in FlywayEndpoint with schema baseline #14019

Closed
wants to merge 3 commits into from
Closed

NullPointerException in FlywayEndpoint with schema baseline #14019

wants to merge 3 commits into from

Conversation

ayudovin
Copy link
Contributor

@ayudovin ayudovin commented Aug 8, 2018

Fixing nullPointerException in FlywayEndpoint with schema baseline.
this bug

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 8, 2018
wilkinsona
wilkinsona requested changes Aug 8, 2018
View reviewed changes
Copy link
Member

@wilkinsona wilkinsona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Rather than using Optional.ofNullable for this sort of thing, our code style is to use (thing != null) ? thing: somethingElse instead. Would you like to update the PR to do that?

@ayudovin
Copy link
Contributor Author

ayudovin commented Aug 8, 2018

@wilkinsona, ok, i'll update my pull request

@wilkinsona wilkinsona mentioned this pull request Aug 9, 2018
Closed
@wilkinsona wilkinsona changed the title fixing nullPointerException in FlywayEndpoint with schema baseline NullPointerException in FlywayEndpoint with schema baseline Aug 9, 2018
@wilkinsona wilkinsona added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 9, 2018
@wilkinsona wilkinsona added this to the 2.0.x milestone Aug 9, 2018
@wilkinsona wilkinsona added the for: merge-with-amendments Needs some changes when we merge label Aug 9, 2018
@wilkinsona wilkinsona self-assigned this Aug 9, 2018
@wilkinsona wilkinsona removed this from the 2.0.x milestone Aug 9, 2018
wilkinsona pushed a commit that referenced this pull request Aug 9, 2018
@wilkinsona
Fix NPE in FlywayEndpoint when migration.installedOn is null
83fbdc6 
See gh-14019
@wilkinsona wilkinsona added this to the 2.0.5 milestone Aug 9, 2018
wilkinsona added a commit that referenced this pull request Aug 9, 2018
@wilkinsona
Merge pull request #14019 from ayudovin
718372e 
* gh-14019:
  Polish "Fix NPE in FlywayEndpoint when migration.installedOn is null"
  Fix NPE in FlywayEndpoint when migration.installedOn is null
@wilkinsona wilkinsona closed this in 27f5e46 Aug 9, 2018
@wilkinsona
Copy link
Member

@ayudovin Thank you very much for making your first contribution to Spring Boot. The proposed changes are now in 2.0.x and master. I also applied a little bit of polish, primarily to add a test so that we don't inadvertently break this again in the future.

@ayudovin
Copy link
Contributor Author

ayudovin commented Aug 9, 2018

@wilkinsona, yeah, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilkinsona wilkinsona wilkinsona requested changes

Assignees

@wilkinsona wilkinsona

Labels
for: merge-with-amendments Needs some changes when we merge type: bug A general bug
Projects
None yet
Milestone
2.0.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ayudovin @wilkinsona @spring-projects-issues