Skip to content

Commit

Permalink
Merge pull request #14019 from ayudovin
Browse files Browse the repository at this point in the history
* gh-14019:
  Polish "Fix NPE in FlywayEndpoint when migration.installedOn is null"
  Fix NPE in FlywayEndpoint when migration.installedOn is null
  • Loading branch information
wilkinsona committed Aug 9, 2018
2 parents 26af0ca + 27f5e46 commit 718372e
Show file tree
Hide file tree
Showing 4 changed files with 47 additions and 4 deletions.
Expand Up @@ -17,6 +17,7 @@
package org.springframework.boot.actuate.flyway;

import java.time.Instant;
import java.util.Date;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
Expand All @@ -38,6 +39,7 @@
* @author Eddú Meléndez
* @author Phillip Webb
* @author Andy Wilkinson
* @author Artsiom Yudovin
* @since 2.0.0
*/
@Endpoint(id = "flyway")
Expand Down Expand Up @@ -164,15 +166,19 @@ private FlywayMigration(MigrationInfo info) {
this.script = info.getScript();
this.state = info.getState();
this.installedBy = info.getInstalledBy();
this.installedOn = Instant.ofEpochMilli(info.getInstalledOn().getTime());
this.installedRank = info.getInstalledRank();
this.executionTime = info.getExecutionTime();
this.installedOn = nullSafeToInstant(info.getInstalledOn());
}

private String nullSafeToString(Object obj) {
return (obj != null) ? obj.toString() : null;
}

private Instant nullSafeToInstant(Date date) {
return (date != null) ? Instant.ofEpochMilli(date.getTime()) : null;
}

public MigrationType getType() {
return this.type;
}
Expand Down
Expand Up @@ -16,9 +16,13 @@

package org.springframework.boot.actuate.flyway;

import java.util.Map;

import org.junit.Test;

import org.springframework.boot.actuate.flyway.FlywayEndpoint.FlywayDescriptor;
import org.springframework.boot.autoconfigure.flyway.FlywayAutoConfiguration;
import org.springframework.boot.autoconfigure.flyway.FlywayMigrationStrategy;
import org.springframework.boot.autoconfigure.jdbc.EmbeddedDataSourceConfiguration;
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
import org.springframework.context.ApplicationContext;
Expand All @@ -40,9 +44,28 @@ public class FlywayEndpointTests {
@Test
public void flywayReportIsProduced() {
new ApplicationContextRunner().withUserConfiguration(Config.class)
.run((context) -> assertThat(
context.getBean(FlywayEndpoint.class).flywayBeans().getContexts()
.get(context.getId()).getFlywayBeans()).hasSize(1));
.run((context) -> {
Map<String, FlywayDescriptor> flywayBeans = context
.getBean(FlywayEndpoint.class).flywayBeans().getContexts()
.get(context.getId()).getFlywayBeans();
assertThat(flywayBeans).hasSize(1);
assertThat(flywayBeans.values().iterator().next().getMigrations())
.hasSize(3);
});
}

@Test
public void whenFlywayHasBeenBaselinedFlywayReportIsProduced() {
new ApplicationContextRunner()
.withUserConfiguration(BaselinedFlywayConfig.class, Config.class)
.run((context) -> {
Map<String, FlywayDescriptor> flywayBeans = context
.getBean(FlywayEndpoint.class).flywayBeans().getContexts()
.get(context.getId()).getFlywayBeans();
assertThat(flywayBeans).hasSize(1);
assertThat(flywayBeans.values().iterator().next().getMigrations())
.hasSize(3);
});
}

@Configuration
Expand All @@ -56,4 +79,18 @@ public FlywayEndpoint endpoint(ApplicationContext context) {

}

@Configuration
public static class BaselinedFlywayConfig {

@Bean
public FlywayMigrationStrategy baseliningMigrationStrategy() {
return (flyway) -> {
flyway.setBaselineVersionAsString("2");
flyway.baseline();
flyway.migrate();
};
}

}

}
Empty file.
Empty file.

0 comments on commit 718372e

Please sign in to comment.