Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reuse WebsocketServerSpec.Builder between requests for #2159 #2160

Closed
wants to merge 1 commit into from
Closed

Do not reuse WebsocketServerSpec.Builder between requests for #2159 #2160

wants to merge 1 commit into from

Conversation

Johannes-Rost
Copy link
Contributor

A possible Fix for #2159

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #2160 (e0eeea4) into master (329efa8) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2160      +/-   ##
============================================
+ Coverage     77.10%   77.13%   +0.02%     
- Complexity     1277     1279       +2     
============================================
  Files           164      164              
  Lines          4904     4906       +2     
  Branches        403      403              
============================================
+ Hits           3781     3784       +3     
  Misses          913      913              
+ Partials        210      209       -1     
Impacted Files Coverage Δ Complexity Δ
...cloud/gateway/config/GatewayAutoConfiguration.java 86.78% <100.00%> (+0.15%) 70.00 <0.00> (ø)
...eway/filter/factory/RetryGatewayFilterFactory.java 77.97% <0.00%> (+0.59%) 38.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 329efa8...e0eeea4. Read the comment docs.

@Johannes-Rost
Copy link
Contributor Author

Could someone please comment if this pull request is acceptable as is or if I need to add or change something? The linked error currently prevents us from updating Spring Cloud Gateway to version 3.

@spencergibb
Copy link
Member

Cherry picked to 2.2.x and merged forward to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReactorNettyRequestUpgradeStrategy WebSocket sub protocol handling broken in GatewayAutoConfiguration
4 participants